Skip to content

[css-grid-2] 12.1. Grid Sizing Algorithm Step 4 should also include columns in some cases #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KurtCattiSchmidt opened this issue Mar 18, 2021 · 2 comments

Comments

@KurtCattiSchmidt
Copy link

https://drafts.csswg.org/css-grid-2/#algo-overview

"4. Next, if the min-content contribution of any grid item has changed based on the column sizes and alignment calculated in step 3, re-resolve the sizes of the grid rows with the new min-content and max-content contributions (once only)."

It seems like the columns also have to be resized if there are orthogonal grid items, or items with an aspect ratio that changed based on contribution size.

@bfgeek bfgeek added css-grid-1 css-grid-2 Subgrid; Current Work labels Mar 19, 2021
@tabatkins
Copy link
Member

tabatkins commented Jun 16, 2021

@KurtCattiSchmidt One of the original design decisions by the team at Microsoft who came up with the grid layout algorithm was to limit the number of cycles through row & column sizing to two passes, so that grid layout with items that have a cross-axis dependency don't cause an indefinite number of cycles. (It's not clear that the layout algorithm is actually guaranteed to converge.) Are you asking to increase the number of passes in the algorithm?

@tabatkins
Copy link
Member

@KurtCattiSchmidt ping? If you have a strong reason (based on real content getting badly formatted?) to do additional passes, please let us know, otherwise we'll close this issue as Timed Out next time we do triage thru the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants