Skip to content

[css-align-3] Import auto-margin handling from CSS2 #6390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tabatkins opened this issue Jun 16, 2021 · 1 comment
Open

[css-align-3] Import auto-margin handling from CSS2 #6390

tabatkins opened this issue Jun 16, 2021 · 1 comment
Labels

Comments

@tabatkins
Copy link
Member

The Align spec needs to interact with "auto" margins in a few spots, and currently attempts to do so by monkeypatching the CSS2 algos. This misses some cases, and is generally unclear. We should import all of the auto-margin handling into Align so it can have a single correct definition.

(In particular, we need a clear answer for what to do when you have auto margins and are overconstrained; the current mentions of "overconstrained" in the spec actually assume you have fixed margins, once you dig into their reasoning.)

@tabatkins tabatkins added the css-align-3 Current Work label Jun 16, 2021
@fantasai
Copy link
Collaborator

I think that we should defer these to the relevant layout module, aside from block layout which we will unfortunately need to handle here for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants