-
Notifications
You must be signed in to change notification settings - Fork 719
[css-color-5] incorrect WPT tests for omitted alpha in relative color syntax #8708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
(forgot to ping @svgeesus ) |
No, it was two years ago
|
Thanks for PR updating the WPT. Before approving, I need to check the right ranges are used, in the case where alpha is used as one of the color channels, particularly for Using 0,1 alpha works better for Plus, mixing up the channels like this doesn't have much of a practical use case. I can't think when it might be useful in practice to have a red, green or blue value depend on the origin alpha. (And no it can't be used for premultiplication either because these are gamma-encoded color component values). |
@svgeesus I think there is some confusion here. This issue and the test changes are not related to using So the ranges shouldn't be a factor. The specification dictates that there is some form of "pass through" for |
The WPT tests were approved and merged, so I think we can close this @svgeesus ? |
https://drafts.csswg.org/css-color-5/#origin-color
https://github.com/web-platform-tests/wpt/blob/master/css/css-color/parsing/color-computed-relative-color.html#L104
The alpha channel is omitted, so alpha should be taken from the origin color.
The result should be :
rgb(0, 10, 10, 0.8)
Maybe this is a fairly recent change to the specification?
I've updated the WPT tests to match the specification : web-platform-tests/wpt#39508
The text was updated successfully, but these errors were encountered: