Skip to content

[cssom-1] font-family descriptor should not be serialized if not present, fix #13323 #13847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svgeesus merged 1 commit into from
Apr 28, 2026
Merged

[cssom-1] font-family descriptor should not be serialized if not present, fix #13323 #13847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cssom-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1899,9 +1899,13 @@ To <dfn export>serialize a CSS rule</dfn>, perform one of the following in accor
The result of concatenating the following:
<ol>
<li>The string "<code>@font-face {</code>", followed by a single SPACE (U+0020).</li>
<li>The string "<code>font-family:</code>", followed by a single SPACE (U+0020).</li>
<li>The result of performing <a>serialize a string</a> on the rule’s font family name.</li>
<li>The string "<code>;</code>", i.e., SEMICOLON (U+003B).
<li>If the '@font-face/font-family' descriptor is present:
<ol>
<li>The string "<code>font-family:</code>", followed by a single SPACE (U+0020).</li>
Comment on lines 1901 to +1904

@AtkinsSJ AtkinsSJ Apr 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm late, but I think the space added in step 1 also needs changing, to be added in step 2.1 instead. Otherwise, if there is no font-family, then step 3.1 below will mean there are two spaces between the { and the first descriptor name.

<li>The result of performing <a>serialize a string</a> on the rule’s font family name.</li>
<li>The string "<code>;</code>", i.e., SEMICOLON (U+003B).</li>
</ol>
</li>
<li>
If the rule's associated source list is not empty, follow these substeps:
<ol>
Expand Down