[css-backgrounds-4] Extend position-three to include logical/physical keywords#13954
Open
keithamus wants to merge 1 commit into
Conversation
Member
Author
|
@LeaVerou @fantasai @SebastianZ - thoughts? |
Member
|
This makes sense to me, and seems like a spec bug. To avoid similar drift in the future, I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<bg-position>incss-backgrounds-4is defined as:<position>(fromcss-values-5) already includes logical keywords (x-start,x-end,y-start,y-end,block-start,block-end,inline-start,inline-end,start,end). Meaning one can write:However
<position-three>is physical-only. Is this an intentional omission? This means one cannot elide the length, even when it's the same value, for example all of these are currently invalid:And of course these keywords already work in longhand properties properties, so these are valid today:
I think we can update
<position-three>to:This allows for a three-value syntax where the "side" specified preceding the
<length-percentage>is the effecting side, as it is today.I was going to file an issue but a PR felt about as much work, so either way we can discuss or close, or if you'd rather see this as an issue then I can also do that.