8000 [css-align] Add 2nd single-quote around 'align-self/stretch' by dholbert · Pull Request #2985 · w3c/csswg-drafts · GitHub
Skip to content

[css-align] Add 2nd single-quote around 'align-self/stretch'#2985

Merged
tabatkins merged 1 commit into
masterfrom
dholbert-patch-1
Aug 3, 2018
Merged

[css-align] Add 2nd single-quote around 'align-self/stretch'#2985
tabatkins merged 1 commit into
masterfrom
dholbert-patch-1

Conversation

@dholbert
Copy link
Copy Markdown
Member

@dholbert dholbert commented Aug 3, 2018

There's a missing single quote here, which means this one instance of align-self/stretch gets quoted directly in the spec, with broken linkification around it. Here's the affected section if you're curious:
https://drafts.csswg.org/css-align/#baseline-content-alignment

And here's a screenshot (good for 14 days):
https://screenshots.firefox.com/V5tvNjkCu5juNkoF/drafts.csswg.org

Looks like we're just missing a single quote here. This pull request adds the missing single-quote to fix it.

[css-spec-shortname-1] Brief description which should also include the #issuenum-or-URL and/or link to relevant CSSWG minutes.

Copy the above line into the Title and replace with the relevant details. Fill in any additional details here. See https://github.com/w3c/csswg-drafts/blob/master/CONTRIBUTING.md for more info.

There's a missing single quote here, which means this one instance of  align-self/stretch gets quoted directly in the spec, with broken linkification around it. Here's the affected section if you're curious:
 https://drafts.csswg.org/css-align/#baseline-content-alignment

And here's a screenshot (good for 14 days):
  https://screenshots.firefox.com/V5tvNjkCu5juNkoF/drafts.csswg.org

Looks like we're just missing a single quote here. This pull request adds the missing single-quote to fix it.
@dholbert dholbert requested a review from tabatkins August 3, 2018 17:21
@dholbert dholbert added the css-align-3 Current Work label Aug 3, 2018
@dholbert
Copy link
Copy Markdown
Member Author

dholbert commented Aug 3, 2018

PR has contribution issues. The following users' affiliation could not be dete...

I fixed this now, BTW (I've just linked my github account at my w3c "connectedaccounts" page).

@tabatkins tabatkins merged commit 5511dac into master Aug 3, 2018
@dholbert dholbert deleted the dholbert-patch-1 branch August 3, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css-align-3 Current Work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants