The AnimationPlayState enumeration

From b4f26d41b609d4f48de65784374f8e277822ddef Mon Sep 17 00:00:00 2001
From: Brian Birtles 
Date: Mon, 22 Apr 2019 10:23:51 +0900
Subject: [PATCH 5/9] [web-animations-1] Rename "ok" replace state to "active"

---
 web-animations-1/Overview.bs | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/web-animations-1/Overview.bs b/web-animations-1/Overview.bs
index fe2d910c333..eeb0159caaf 100644
--- a/web-animations-1/Overview.bs
+++ b/web-animations-1/Overview.bs
@@ -3743,12 +3743,12 @@ automatically removed unless the author explicitly requests they be retained.
 An [=animation=] maintains a replace state that may be one of the
 following values:
 
-* ok
+* active
 * removed
 * persisted
 
 The initial value of an [=animation=]'s [=replace state=] is
-[=ok replace state|ok=].
+[=active replace state|active=].
 
 The [=animation effects=] of an [=animation=]
 whose [=replace state=] is [=removed replace state|removed=]
@@ -3782,7 +3782,7 @@ then for every [=animation=], |animation|, that:
 
 *   is [=replaceable=], and
 
-*   has a [=replace state=] of [=ok replace state|ok=], and
+*   has a [=replace state=] of [=active replace state|active=], and
 
 *   for which there exists for each [=target property=]
     of every [=animation effect=]
@@ -4262,11 +4262,11 @@ enum AnimationPlayState { "idle", "running", "paused", "finished" };
 
The AnimationReplaceState enumeration
 
 
-enum AnimationReplaceState { "ok", "removed", "persisted" };
+enum AnimationReplaceState { "active", "removed", "persisted" };
 
 
-:   ok
-::  Corresponds to the [=ok replace state=].
+:   active
+::  Corresponds to the [=active replace state=].
 :   removed
 ::  Corresponds to the [=removed replace state=].
 :   persisted

From 0c38b54821aa5b27d9643c6694e4f4cd5aa0ddc4 Mon Sep 17 00:00:00 2001
From: Brian Birtles 
Date: Mon, 22 Apr 2019 10:44:00 +0900
Subject: [PATCH 6/9] [web-animations-1] Various editorial tweaks

---
 web-animations-1/Overview.bs | 38 +++++++++++++++++++++++-------------
 1 file changed, 24 insertions(+), 14 deletions(-)

diff --git a/web-animations-1/Overview.bs b/web-animations-1/Overview.bs
index eeb0159caaf..dc1af99f36d 100644
--- a/web-animations-1/Overview.bs
+++ b/web-animations-1/Overview.bs
@@ -3762,8 +3762,8 @@ if all of the following conditions are true:
 
 *   The existence of the [=animation=] is not prescribed by markup.
     That is, it is not
-    a CSS animation with an [=owning element (animation)|owning element=], or
-    a CSS transition with an [=owning element (transition)|owning element=].
+    a CSS animation with an [=owning element (animation)|owning element=],
+    nor a CSS transition with an [=owning element (transition)|owning element=].
 *   The [=animation=]'s [=play state=] is [=finished play state|finished=].
 *   The [=animation=]'s [=replace state=] is not
     [=removed replace state|removed=].
@@ -3789,7 +3789,7 @@ then for every [=animation=], |animation|, that:
     [=associated with an animation|associated=] with |animation|,
     an [=animation effect=] associated with a [=replaceable=] [=animation=]
     with a higher [=composite order=] than |animation|
-    that includes the same [=target property=].
+    that includes the same [=target property=]
 
 perform the following steps:
 
@@ -3811,9 +3811,11 @@ perform the following steps:
 1.   If |animation| has a [=document for timing=], then append
      |removeEvent| to its [=document for timing=]'s
      [=pending animation event queue=] along with its target, |animation|.
-     For the [=scheduled event time=], use the result of converting
-     |animation|'s [=target effect end=] to an origin-relative time.
+     For the [=scheduled event time=], use the result of
+     applying the procedure to convert
+     [=timeline time to origin-relative time=] to
+     the [=timeline current time|current time=] of the [=timeline=]
+     with which |animation| is associated.
 
      Otherwise, [=queue a task=] to [=dispatch=] |removeEvent| at
      |animation|.
@@ -4112,7 +4114,7 @@ interface Animation : EventTarget {
 :   void persist()
 ::  Sets this animation's [=replace state=] to
     [=persisted replace state|persisted=].
-:   void commitStyles()
+:   void commitStyles(properties)
 ::  Writes the current [=effect values=]
     produced by this animation's [=animation effects=]
     to their corresponding [=target elements=]' inline style
@@ -4123,8 +4125,8 @@ interface Animation : EventTarget {
     

 
       This is useful for retaining the effect of an animation after it has been
-      removed (see [[#removing-replaced-animations]]) or canceled without
-      retaining the actual animation.
+      removed (see [[#removing-replaced-animations]]) without retaining the
+      actual animation.
 
       Note that the values committed are the computed values
       produced by the [=animation effects=] at the time when this method is
@@ -4140,6 +4142,10 @@ interface Animation : EventTarget {
       but note that doing so will mean the animation continues to consume
       resources.
 
+      Also note that as with other methods defined on this interface,
+      calling this method does not trigger a [=style change event=]
+      (see [[#model-liveness]]).
+
     
 
     

@@ -4155,7 +4161,7 @@ interface Animation : EventTarget {
 
 
 To commit computed styles for an [=animation=],
-|animation|, given an optional list of property names, |properties|:
+|animation|, given an optional list of CSS property names, |properties|:
 
 1.   Let |longhandProperties| be an empty [=ordered set|set=] of
      CSS property names.
@@ -4168,13 +4174,17 @@ To commit computed styles for an [=animation=],
 
      1.   For each CSS property name, |propertyName|, in |properties|:
 
-          1.   If |propertyName| corresponds to a CSS shorthand property name,
-               append each longhand property
+          

+
+          :    If |propertyName| corresponds to a CSS shorthand property name,
+          ::   append each longhand property
                that |propertyName| maps to,
                to |longhandProperties|.
 
-          1.   Otherwise,
-               append |propertyName| to |longhandProperties|.
+          :    Otherwise,
+          ::   append |propertyName| to |longhandProperties|.
+
+          
 
 1.   Let |targets| be the [=ordered set|set=] of all [=target elements=]
      for [=animation effects=] [=associated with an animation|associated=]

From 5f0df9a6abe809ba580f5a6b2d3fbc2cff336864 Mon Sep 17 00:00:00 2001
From: Brian Birtles 
Date: Tue, 23 Apr 2019 10:38:46 +0900
Subject: [PATCH 7/9] [web-animations-1] Tweak commitStyles comment

---
 web-animations-1/Overview.bs | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/web-animations-1/Overview.bs b/web-animations-1/Overview.bs
index dc1af99f36d..c5c724ae3ec 100644
--- a/web-animations-1/Overview.bs
+++ b/web-animations-1/Overview.bs
@@ -4124,9 +4124,12 @@ interface Animation : EventTarget {
 
     

 
-      This is useful for retaining the effect of an animation after it has been
-      removed (see [[#removing-replaced-animations]]) without retaining the
-      actual animation.
+      Since the procedure to [=commit computed styles=] includes the
+      [=effect values=] for the animation even if it is
+      [=removed replace state|removed=],
+      this method is useful for retaining the effect of an animation
+      after it has been replaced (see [[#removing-replaced-animations]])
+      without retaining the actual animation.
 
       Note that the values committed are the computed values
       produced by the [=animation effects=] at the time when this method is

From 0292de9d99531ac700246728a193a77202eea588 Mon Sep 17 00:00:00 2001
From: Brian Birtles 
Date: Tue, 23 Apr 2019 10:54:33 +0900
Subject: [PATCH 8/9] [web-animations-1] Make commitStyles flush

---
 web-animations-1/Overview.bs | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/web-animations-1/Overview.bs b/web-animations-1/Overview.bs
index c5c724ae3ec..c36d8ed6df0 100644
--- a/web-animations-1/Overview.bs
+++ b/web-animations-1/Overview.bs
@@ -4122,6 +4122,9 @@ interface Animation : EventTarget {
     passing {{Animation/commitStyles(properties)/properties}}
     as the list of property names.
 
+    Unlike most other methods defined on this interface, calling this method
+    does trigger a [=style change event=] (see [[#model-liveness]]).
+
     

 
       Since the procedure to [=commit computed styles=] includes the
@@ -4145,10 +4148,6 @@ interface Animation : EventTarget {
       but note that doing so will mean the animation continues to consume
       resources.
 
-      Also note that as with other methods defined on this interface,
-      calling this method does not trigger a [=style change event=]
-      (see [[#model-liveness]]).
-
     
 
     

@@ -4202,10 +4201,23 @@ To commit computed styles for an [=animation=],
           throw a "{{NoModificationAllowedError}}" {{DOMException}}
           and abort these steps.
 
-     1.   If |target| is not [=being rendered=],
+     1.   If, after applying any pending style changes,
+          |target| is not [=being rendered=],
           throw an "{{InvalidStateError}}" {{DOMException}}
           and abort these steps.
 
+          

+
+          The definition of [=being rendered=] [[!HTML]] with regards to
+          ''display: contents'' is still under discussion.
+          For the purpose of this procedure, we assume that an
+          element with ''display: contents'' that otherwise would have
+          associated layout boxes (i.e. it is [=connected=] and not part of
+          a ''display: none'' subtree) is being rendered.
+
+          
+
      1.   Let |physicalProperties| be a [=ordered set|set=] of CSS property
           names with the same contents as |longhandProperties| but
           with each logical property name in |longhandProperties|

From 5ebd26186c54ee8533002708b4d610c357ce2cb9 Mon Sep 17 00:00:00 2001
From: Brian Birtles 
Date: Wed, 8 May 2019 09:48:31 +0900
Subject: [PATCH 9/9] [web-animations] Drop properties parameter from
 commitStyles

---
 web-animations-1/Overview.bs | 55 +++---------------------------------
 1 file changed, 4 insertions(+), 51 deletions(-)

diff --git a/web-animations-1/Overview.bs b/web-animations-1/Overview.bs
index c36d8ed6df0..1b613b0b5d5 100644
--- a/web-animations-1/Overview.bs
+++ b/web-animations-1/Overview.bs
@@ -3965,7 +3965,7 @@ interface Animation : EventTarget {
     void updatePlaybackRate (double playbackRate);
     void reverse ();
     void persist ();
-    void commitStyles (optional sequence<DOMString> properties);
+    void commitStyles ();
 };