[css-highlight-api-1] Rename HighlightsRegister to HighlightRegistry#6003
Conversation
Member
Author
|
@frivoal Mind taking a look at this? |
Member
Author
|
@frivoal I'm going to go ahead and merge this since it is just a rename and largely editorial. Let me know if you have any concerns. I can always put in a follow up change. |
Collaborator
|
Sorry for the slow reaction. Yeah, this change is a good idea, thanks for doing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name HighlightRegistry makes more sense for this concept - a place with Highlight objects are registered. It also follows prior art established by CustomElementRegistry.
Closes #5760