From 2f04d61af8c7c0c436dd0c7af37224667a2c89cb Mon Sep 17 00:00:00 2001 From: jakearchibald Date: Thu, 3 Nov 2022 11:08:03 +0000 Subject: [PATCH 1/3] Fix whitespace, markdown, and promise refs --- css-view-transitions-1/Overview.bs | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/css-view-transitions-1/Overview.bs b/css-view-transitions-1/Overview.bs index d8574032dff..cb9ecafd65e 100644 --- a/css-view-transitions-1/Overview.bs +++ b/css-view-transitions-1/Overview.bs @@ -13,6 +13,7 @@ Editor: Tab Atkins-Bittner, Google, http://xanthir.com/contact/, w3cid 42199 Editor: Jake Archibald, Google, w3cid 76394 Editor: Khushal Sagar, Google, w3cid 122787 Abstract: This module defines the View Transition API, along with associated properties and pseudo-elements. +Markup Shorthands: css no, markdown yes 
@@ -21,6 +22,7 @@ spec:css-position-3; type:property
     text: inset-block-start
     text: inset-inline-start
 spec:css-shapes-3; type:function; text:rect()
+spec:webidl; type:interface; text:Promise
@@ -59,7 +61,7 @@ This spec describes the CSS and JS mechanics of the single-page transition API. A key part of this API design is the view that an animated transition is an enhancement to a DOM change. Specifically, there are two components of the API: -the DOM change, and the visual state animation. +the DOM change, and the visual state animation. In order for the user-agent to generate a set of snapshots prior to the DOM change, the API is designed to take the DOM change callback as part of the @@ -897,19 +899,19 @@ The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=Vi To update transition DOM given a {{ViewTransition}} |transition|: 1. Let |document| be |transition|'s [=relevant global object's=] [=associated document=]. - - 1. Let |hasActiveAnimations| be a boolean, initially false. For each [=page-transition pseudo-elements=] + + 1. Let |hasActiveAnimations| be a boolean, initially false. For each [=page-transition pseudo-elements=] associated with |transition|: - + 1. Let |element| be the [=page-transition pseudo-element=]. - + 1. For each |animation| that contains at least one [=animation effect=] whose [=effect target=] is |element| and whose associated [=animation timeline=] is of type [=document timeline=], set |hasActiveAnimations| to true if any of the following conditions is true: - + 1. |animation| is in paused or running state. - + 1. [=pending-animation-event-queue=] has any events associated with |animation|. 1. If |hasActiveAnimations| is false: From 5e623ebfbecb438f5d6038337f73725e4e677358 Mon Sep 17 00:00:00 2001 From: jakearchibald Date: Thu, 3 Nov 2022 12:34:30 +0000 Subject: [PATCH 2/3] Consistent rendering opportunity references --- css-view-transitions-1/Overview.bs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/css-view-transitions-1/Overview.bs b/css-view-transitions-1/Overview.bs index cb9ecafd65e..0a233467d19 100644 --- a/css-view-transitions-1/Overview.bs +++ b/css-view-transitions-1/Overview.bs @@ -486,7 +486,9 @@ callback UpdateDOMCallback = Promise (); 1. Set |document|'s [=active DOM transition=] to |transition|. - Note: The process continues in [=perform an outgoing capture=] which is executed at the next [=rendering-opportunity=]. + Note: The process continues in [=perform an outgoing capture=] which is executed at the next [=rendering opportunity=]. + + Issue: Waiting on [html/8469](https://github.com/whatwg/html/pull/8468) to reference "rendering opportunity". 1. Return |transition|. @@ -645,10 +647,12 @@ The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=Vi Note: The aim is to prevent unintended DOM updates from being presented to the user after a cached snapshot for the elements has been captured. We wait for - one rendering opportunity after prepare to present DOM mutations made by the + one [=rendering opportunity=] after prepare to present DOM mutations made by the author before prepare to be presented to the user. This is also the content captured in snapshots. + Issue: Waiting on [html/8469](https://github.com/whatwg/html/pull/8468) to reference "rendering opportunity". + Note: These steps will be added to the [=update the rendering=] in the HTML spec. As such, the prose style is written to match other steps in that algorithm. From f53a2f0e14c61dbb78b36c5f276cf4559a893284 Mon Sep 17 00:00:00 2001 From: jakearchibald Date: Thu, 3 Nov 2022 15:31:47 +0000 Subject: [PATCH 3/3] Create issues for things causing bikeshed warnings --- css-view-transitions-1/Overview.bs | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/css-view-transitions-1/Overview.bs b/css-view-transitions-1/Overview.bs index 0a233467d19..5e7617ab1b2 100644 --- a/css-view-transitions-1/Overview.bs +++ b/css-view-transitions-1/Overview.bs @@ -749,6 +749,8 @@ The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=Vi Note: A task is queued here because the texture read back in [=capturing the image=] may be async, although the render steps in the HTML spec act as if it's synchronous. + Issue: "DOM manipulation task source" doesn't link due to a [bikeshed bug](https://github.com/tabatkins/bikeshed/issues/2382). + 1. If |transition|'s [=ViewTransition/phase=] is "`done`", then abort these steps. Note: This happens if |transition| was [=skip the page transition|skipped=] before this point. @@ -904,19 +906,25 @@ The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=Vi 1. Let |document| be |transition|'s [=relevant global object's=] [=associated document=]. - 1. Let |hasActiveAnimations| be a boolean, initially false. For each [=page-transition pseudo-elements=] - associated with |transition|: + 1. Let |hasActiveAnimations| be a boolean, initially false. + + 1. For each [=page-transition pseudo-elements=] associated with |transition|: 1. Let |element| be the [=page-transition pseudo-element=]. - 1. For each |animation| that contains at least one [=animation effect=] - whose [=effect target=] is |element| and whose associated [=animation timeline=] - is of type [=document timeline=], set |hasActiveAnimations| to true if any of the - following conditions is true: + 1. For each |animation| whose [=timeline=] is a [=document timeline=] associated with |document|, + and contains at least one [=animation/associated effect=] whose [=effect target=] is |element|, + set |hasActiveAnimations| to true if any of the following conditions is true: + + Issue: The prose around "effect target" is incorrect, but [#8001](https://github.com/w3c/csswg-drafts/issues/8001) needs to land before it can be fixed. + + - |animation|'s [=animation/play state=] is [=idle play state=] or [=running play state=]. + + Issue: These terms aren't linking due to [#8003](https://github.com/w3c/csswg-drafts/issues/8003). - 1. |animation| is in paused or running state. + - |document|'s [=pending animation event queue=] has any events associated with |animation|. - 1. [=pending-animation-event-queue=] has any events associated with |animation|. + Issue: This prose isn't quite right, but it's blocked on [#8004](https://github.com/w3c/csswg-drafts/issues/8004). 1. If |hasActiveAnimations| is false: