From 5113a1ff0454aaba0520135b8e662ad444d14692 Mon Sep 17 00:00:00 2001 From: Vladimir Levin Date: Wed, 18 Jan 2023 15:50:19 -0500 Subject: [PATCH 1/2] Rename domUpdated to updateCallbackDone --- css-view-transitions-1/Overview.bs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/css-view-transitions-1/Overview.bs b/css-view-transitions-1/Overview.bs index 9c2963db39a..e62b88c6e95 100644 --- a/css-view-transitions-1/Overview.bs +++ b/css-view-transitions-1/Overview.bs @@ -596,7 +596,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; undefined skipTransition(); readonly attribute Promise finished; readonly attribute Promise ready; - readonly attribute Promise domUpdated; + readonly attribute Promise updateCallbackDone; }; @@ -630,7 +630,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; :: a {{Promise}}. Initially [=a new promise=] in [=this's=] [=relevant Realm=]. - : DOM updated promise + : update callback done promise :: a {{Promise}}. Initially [=a new promise=] in [=this's=] [=relevant Realm=]. @@ -655,7 +655,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; The {{ViewTransition/ready}} [=getter steps=] are to return [=this's=] [=ViewTransition/ready promise=]. - The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=ViewTransition/DOM updated promise=]. + The {{ViewTransition/updateCallbackDone}} [=getter steps=] are to return [=this's=] [=ViewTransition/update callback done promise=]. ### {{ViewTransition/skipTransition()}} ### {#ViewTransition-skipTransition} @@ -804,7 +804,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; 1. [=Call the DOM update callback=] of |transition|. - 1. [=promise/React=] to |transition|'s [=ViewTransition/DOM updated promise=]: + 1. [=promise/React=] to |transition|'s [=ViewTransition/update callback done promise=]: * If the promise does not settle within an implementation-defined timeout, then: @@ -906,12 +906,12 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; Note: The ready promise would've been resolved if {{ViewTransition/skipTransition()}} is called after we start animating. - 1. [=promise/React=] to |transition|'s [=ViewTransition/DOM updated promise=]: + 1. [=promise/React=] to |transition|'s [=ViewTransition/update callback done promise=]: - * If |transition|'s [=ViewTransition/DOM updated promise=] was resolved, + * If |transition|'s [=ViewTransition/update callback done promise=] was resolved, then [=resolve=] |transition|'s [=ViewTransition/finished promise=]. - * If |transition|'s [=ViewTransition/DOM updated promise=] was rejected with reason |reason|, + * If |transition|'s [=ViewTransition/update callback done promise=] was rejected with reason |reason|, then [=reject=] |transition|'s [=ViewTransition/finished promise=] with |reason|. @@ -1280,9 +1280,9 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; 1. [=promise/React=] to |callbackPromise|: - * If |callbackPromise| was resolved, then [=resolve=] |transition|'s [=ViewTransition/DOM updated promise=]. + * If |callbackPromise| was resolved, then [=resolve=] |transition|'s [=ViewTransition/update callback done promise=]. - * If |callbackPromise| was rejected with reason |r|, then [=reject=] |transition|'s [=ViewTransition/DOM updated promise=] with |r|. + * If |callbackPromise| was rejected with reason |r|, then [=reject=] |transition|'s [=ViewTransition/update callback done promise=] with |r|. ## [=Clear view transition=] ## {#clear-view-transition-algorithm} From 66655b797e264729d8b3dbe136b0ee9d901b7d4a Mon Sep 17 00:00:00 2001 From: Vladimir Levin Date: Thu, 19 Jan 2023 10:10:01 -0500 Subject: [PATCH 2/2] More renames --- css-view-transitions-1/Overview.bs | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/css-view-transitions-1/Overview.bs b/css-view-transitions-1/Overview.bs index e62b88c6e95..e95bffcce2a 100644 --- a/css-view-transitions-1/Overview.bs +++ b/css-view-transitions-1/Overview.bs @@ -502,10 +502,10 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; partial interface Document { - ViewTransition startViewTransition(optional UpdateDOMCallback? callback = null); + ViewTransition startViewTransition(optional UpdateCallback? callback = null); }; - callback UpdateDOMCallback = Promise<any> (); + callback UpdateCallback = Promise<any> (); ### {{Document/startViewTransition()}} ### {#ViewTransition-prepare} @@ -515,7 +515,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; 1. Let |transition| be a new {{ViewTransition}} object in [=this's=] [=relevant Realm=]. - 1. Set |transition|'s [=ViewTransition/DOM update callback=] to |callback|. + 1. Set |transition|'s [=ViewTransition/update callback=] to |callback|. 1. Let |document| be [=this's=] [=relevant global object's=] [=associated document=]. @@ -523,7 +523,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; then [=skip the view transition=] |document|'s [=active DOM transition=] with an "{{AbortError}}" {{DOMException}} in [=this's=] [=relevant Realm=]. - Note: This can result in two asynchronous [=ViewTransition/DOM update callbacks=] running concurrently. + Note: This can result in two asynchronous [=ViewTransition/update callbacks=] running concurrently. One for the |document|'s current [=active DOM transition=], and another for this |transition|. As per the [design of this feature](#transitions-as-enhancements), it's assumed that the developer is using another feature or framework to correctly schedule these DOM changes. @@ -615,7 +615,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; :: One of the following [=phases=]: 1. "`pending-capture`". - 1. "`dom-update-callback-called`". + 1. "`update-callback-called`". 1. "`animating`". 1. "`done`". @@ -623,8 +623,8 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; It is, however, important to understand what steps happen in each of the phases: when the snapshots are captured, when pseudo-element DOM is created, etc. The description of the phases below tries to be as precise as possible, with an intent to provide an unambiguous set of steps for implementors to follow in order to produce a spec-compliant implementation. - : DOM update callback - :: an {{UpdateDOMCallback}} or null. Initially null. + : update callback + :: an {{UpdateCallback}} or null. Initially null. : ready promise :: a {{Promise}}. @@ -802,7 +802,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; Note: This happens if |transition| was [=skip the view transition|skipped=] before this point. - 1. [=Call the DOM update callback=] of |transition|. + 1. [=Call the update callback=] of |transition|. 1. [=promise/React=] to |transition|'s [=ViewTransition/update callback done promise=]: @@ -894,7 +894,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; 1. [=Assert=]: |transition|'s [=ViewTransition/phase=] is not "`done`". - 1. If |transition|'s [=ViewTransition/phase=] is [=phases/before=] "`dom-update-callback-called`", then [=call the DOM update callback=] of |transition|. + 1. If |transition|'s [=ViewTransition/phase=] is [=phases/before=] "`update-callback-called`", then [=call the update callback=] of |transition|. 1. Set [=document/transition suppressing rendering=] to false. @@ -1266,17 +1266,17 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn;
- To call the DOM update callback of a {{ViewTransition}} |transition|: + To call the update callback of a {{ViewTransition}} |transition|: - 1. [=Assert=]: |transition|'s [=ViewTransition/phase=] is [=phases/before=] "`dom-update-callback-called`". + 1. [=Assert=]: |transition|'s [=ViewTransition/phase=] is [=phases/before=] "`update-callback-called`". 1. Let |callbackPromise| be [=a new promise=] in |transition|'s [=relevant Realm=]. - * If |transition|'s [=ViewTransition/DOM update callback=] is null, then resolve |callbackPromise|. + * If |transition|'s [=ViewTransition/update callback=] is null, then resolve |callbackPromise|. - * Otherwise, let |callbackPromise| be the result of [=/invoking=] |transition|'s [=ViewTransition/DOM update callback=]. + * Otherwise, let |callbackPromise| be the result of [=/invoking=] |transition|'s [=ViewTransition/update callback=]. - 1. Set |transition|'s [=ViewTransition/phase=] to "`dom-update-callback-called`". + 1. Set |transition|'s [=ViewTransition/phase=] to "`update-callback-called`". 1. [=promise/React=] to |callbackPromise|: