[various] Replace optional group with implicitly optional comma #8480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8d97d4 to
c0c43d3
Compare
Member
Looks like it, yeah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editorial change replacing explicit optional groups with implicitly optional commas, ie.
... [ , ... ]?with... , ...?.I would appreciate this change because parsing against these two syntaxes with the CSS parser I am using, produces two different results (ie.
List(..., optionalList(comma, ...))vs.List(..., comma, ...)), and the second is easier to handle.I searched for all occurrences with
/\[\s*,.+\]\s*\?/. I did not replace the result found in the value definition ofcopy-into(CSS GCPM 4, not ready for implementation): the whole alternation can be omitted, which seems to be a bug.It should probably be
none | [ <custom-ident> <content-level> ]#.