From 3d9610c22370f34a216f62b8a3dd0d0b29e7f37e Mon Sep 17 00:00:00 2001 From: fantasai Date: Mon, 12 Jun 2023 21:14:37 -0400 Subject: [PATCH 1/4] [css-view-transitions-1][editorial] Minor tweaks to API prose --- css-view-transitions-1/Overview.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/css-view-transitions-1/Overview.bs b/css-view-transitions-1/Overview.bs index fbe7febe6e0..b4a8d9ebc04 100644 --- a/css-view-transitions-1/Overview.bs +++ b/css-view-transitions-1/Overview.bs @@ -953,7 +953,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; Note: The View Transition API wraps a DOM change and creates a visual transition. However, sometimes you don't care about the success/failure of the transition animation, you just want to know if and when the DOM change happens. - {{ViewTransition/updateCallbackDone}} is for that use-case. + {{ViewTransition/updateCallbackDone}} is for that use-case.) : {{ViewTransition|viewTransition}}.{{ViewTransition/ready}} :: A promise that fulfills once the pseudo-elements for the transition are created, From f4b82166b9cec881da4614e21d63667ae15ef1d8 Mon Sep 17 00:00:00 2001 From: fantasai Date: Tue, 13 Jun 2023 00:09:38 -0400 Subject: [PATCH 2/4] [css-view-transitions-1][editorial] Rename rendering suppression variable --- css-view-transitions-1/Overview.bs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/css-view-transitions-1/Overview.bs b/css-view-transitions-1/Overview.bs index b4a8d9ebc04..36517b76717 100644 --- a/css-view-transitions-1/Overview.bs +++ b/css-view-transitions-1/Overview.bs @@ -1073,10 +1073,10 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; : active view transition :: a {{ViewTransition}} or null. Initially null. - : transition suppressing rendering + : rendering suppression for view transitions :: a boolean. Initially false. - While a {{Document}}’s [=document/transition suppressing rendering=] is true, + While a {{Document}}’s [=document/rendering suppression for view transitions=] is true, all pointer hit testing must target its [=document element=], ignoring all other [=elements=]. @@ -1165,7 +1165,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
In the definition for [=rendering opportunity=], add the following condition: - A navigable has no rendering opportunities if active document has [=document/transition suppressing rendering=] set to true. + A navigable has no rendering opportunities if active document has [=document/rendering suppression for view transitions=] set to true. Note: These steps will be added to the [=update the rendering=] in the HTML spec. See #7884 for more context. @@ -1202,7 +1202,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; If failure is returned, then [=skip the view transition=] for |transition| with an "{{InvalidStateError}}" {{DOMException}} in |transition|'s [=relevant Realm=], and return. - 1. Set |document|'s [=document/transition suppressing rendering=] to true. + 1. Set |document|'s [=document/rendering suppression for view transitions=] to true. 1. [=Queue a global task=] on the [=DOM manipulation task source=], given |transition|'s [=relevant global object=], @@ -1251,7 +1251,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; 1. If |transition|'s [=ViewTransition/initial snapshot containing block size=] is not equal to the [=snapshot containing block size=], then [=skip the view transition=] for |transition|, and return. - 1. Set [=document/transition suppressing rendering=] to false. + 1. Set [=document/rendering suppression for view transitions=] to false. 1. [=Capture the new state=] for |transition|. @@ -1528,7 +1528,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; 1. If |transition|'s [=ViewTransition/phase=] is before "`update-callback-called`", then [=queue a global task=] on the [=DOM manipulation task source=], given |transition|'s [=relevant global object=], to [=call the update callback=] of |transition|. - 1. Set [=document/transition suppressing rendering=] to false. + 1. Set [=document/rendering suppression for view transitions=] to false. 1. [=Clear view transition=] |transition|. From 0aa0965ae4bf771721d8d64c6e7100699cc6f806 Mon Sep 17 00:00:00 2001 From: fantasai Date: Tue, 13 Jun 2023 00:30:03 -0400 Subject: [PATCH 3/4] [css-view-transitions-1][editorial] Rename show view transition pseudos boolean --- css-view-transitions-1/Overview.bs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/css-view-transitions-1/Overview.bs b/css-view-transitions-1/Overview.bs index 36517b76717..945329e1b2b 100644 --- a/css-view-transitions-1/Overview.bs +++ b/css-view-transitions-1/Overview.bs @@ -1088,7 +1088,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; Note: This is used to hold dynamic styles relating to transitions. - : show view-transition root pseudo-element + : show view transition tree :: A boolean. Initially false. When this is true, [=this=]'s [=active view transition=]'s [=ViewTransition/transition root pseudo-element=] renders as a child of [=this=]'s [=document element=], @@ -1382,7 +1382,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; 1. Let |document| be [=this's=] [=relevant global object's=] [=associated document=]. - 1. Set |document|'s [=show view-transition root pseudo-element=] to true. + 1. Set |document|'s [=show view transition tree=] to true. 1. [=map/For each=] |transitionName| → |capturedElement| of |transition|'s [=ViewTransition/named elements=]: @@ -1766,7 +1766,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; and |style| is in |document|'s [=document/dynamic view transition style sheet=], then remove |style| from |document|'s [=document/dynamic view transition style sheet=]. - 1. Set |document|'s [=document/show view-transition root pseudo-element=] to false. + 1. Set |document|'s [=document/show view transition tree=] to false. 1. Set |document|'s [=document/active view transition=] to null.
From 34966cd322adabd1926f9d2973779ac2d2270aa3 Mon Sep 17 00:00:00 2001 From: fantasai Date: Tue, 13 Jun 2023 00:53:06 -0400 Subject: [PATCH 4/4] [css-view-transitions-1][editorial] Minor wording tweaks and markup fixes --- css-view-transitions-1/Overview.bs | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/css-view-transitions-1/Overview.bs b/css-view-transitions-1/Overview.bs index 945329e1b2b..e25da5e6855 100644 --- a/css-view-transitions-1/Overview.bs +++ b/css-view-transitions-1/Overview.bs @@ -1092,7 +1092,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; :: A boolean. Initially false. When this is true, [=this=]'s [=active view transition=]'s [=ViewTransition/transition root pseudo-element=] renders as a child of [=this=]'s [=document element=], - and [=this=]'s [=document element=] is its [=originating element=]. + with [=this=]'s [=document element=] is its [=originating element=]. Note: The position of the [=ViewTransition/transition root pseudo-element=] within the [=document element=] does not matter, as the [=ViewTransition/transition root pseudo-element=]'s [=containing block=] is the [=snapshot containing block=]. @@ -1179,7 +1179,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; 1. If |document|'s [=document/active view transition=] is not null, then: 1. If |document|'s [=document/active view transition=]'s [=ViewTransition/phase=] is "`pending-capture`", - then [=setup view transition=] with |document|'s [=document/active view transition=]. + then [=setup view transition=] for |document|'s [=document/active view transition=]. 1. Otherwise, if |document|'s [=document/active view transition=]'s [=ViewTransition/phase=] is "`animating`", then [=handle transition frame=] for |document|'s [=document/active view transition=]. @@ -1188,7 +1188,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; ## [=Setup view transition=] ## {#setup-view-transition-algorithm}
- To setup view transition given a {{ViewTransition}} |transition|, + To setup view transition for a {{ViewTransition}} |transition|, perform the following steps: Note: This algorithm captures the current state of the document, @@ -1330,9 +1330,9 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; |element|'s [=border box=] from the [=snapshot containing block origin=] to its current visual position. - 1. Set |capture|'s [=captured element/old writing-mode] to the [=computed value=] of 'writing-mode' on |element|. + 1. Set |capture|'s [=captured element/old writing-mode=] to the [=computed value=] of 'writing-mode' on |element|. - 1. Set |capture|'s [=captured element/old direction] to the [=computed value=] of 'direction' on |element|. + 1. Set |capture|'s [=captured element/old direction=] to the [=computed value=] of 'direction' on |element|. 1. Set |namedElements|[|transitionName|] to |capture|.
@@ -1400,7 +1400,8 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; 1. Let |old| be a new ''::view-transition-old()'', with its [=view transition name=] set to |transitionName|, - displaying |capturedElement|'s [=captured element/old image=]. + displaying |capturedElement|'s [=captured element/old image=] + as its [=replaced element|replaced=] content. 1. Append |old| to |imagePair|. @@ -1416,7 +1417,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; The [=new element=] and its contents (the flat tree descendants of the element, including both text and elements, or the replaced content of a replaced element), except the |transition|'s [=ViewTransition/transition root pseudo-element=]'s [=tree/inclusive descendants=], - are not painted (as if they had visibility: hidden) + are not painted (as if they had ''visibility: hidden'') and do not respond to hit-testing (as if they had pointer-events: none) until |new| exists. 1. If both of |capturedElement|'s [=captured element/old image=] and [=captured element/new element=] @@ -1481,7 +1482,10 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; Note: The above code example contains variables to be replaced. - Note: ''mix-blend-mode: plus-lighter'' ensures that the blending of identical pixels from the old and new images results in the same color value as those pixels, and achieves a "correct" cross-fade. + Note: ''mix-blend-mode: plus-lighter'' ensures + that the blending of identical pixels from the old and new images + results in the same color value as those pixels, + and achieves a “correct” cross-fade. ## [=Call the update callback=] ## {#call-dom-update-callback-algorithm} @@ -1557,7 +1561,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface; 1. If |element| is the [=document element=], then: - 1. Render the region of the |element| and the [/=document=]'s [=Document/top layer=] that intersects the [=snapshot containing block=], + 1. Render the region of the |element| and the [=/document=]'s [=Document/top layer=] that intersects the [=snapshot containing block=], on a transparent canvas the size of the [=snapshot containing block=], following the [=capture rendering characteristics=], and these additional characteristics: