Skip to content

[css-view-transitions-2] Resolve outbound transition promises after document unloads #9954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khushalsagar merged 2 commits into from
Feb 14, 2024
Merged

[css-view-transitions-2] Resolve outbound transition promises after document unloads #9954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d0e4f7
[css-view-transitions-2] Resolve outbound transition promises after d…
noamr Feb 14, 2024
a2a609e
remove bespoke task
noamr Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions css-view-transitions-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ Markup Shorthands: css yes, markdown yes
spec:css-view-transitions-1;
text: active view transition; type: dfn;
text: capture the old state; type: dfn;
text: clear view transition; type: dfn;
text: activate view transition; type: dfn;
text: skip the view transition; type: dfn;
text: ViewTransition; type: interface;
Expand Down Expand Up @@ -582,11 +581,6 @@ Prepend this to the [=Perform pending transition operations=] algorithm given a
[=view transition params/named elements=] is a [=map/clone=] of |transition|'s [=ViewTransition/named elements=],
and whose [=view transition params/initial snapshot containing block size=] is |transition|'s [=ViewTransition/initial snapshot containing block size=].

1. [=Clear view transition=] |transition|.

Note: The ViewTransition object on the old Document should be destroyed after its state has been copied to the new Document below.
We explicitly clear it here since the old Document may be cached by the UA.

1. Call |transition|'s [=outbound post-capture steps=] given |viewTransitionParams|.
Comment thread
noamr marked this conversation as resolved.


Expand Down Expand Up @@ -678,6 +672,8 @@ Prepend this to the [=Perform pending transition operations=] algorithm given a
1. Let |outboundTransition| be a new {{ViewTransition}} object in |oldDocument|'s [=relevant Realm=],
whose [=ViewTransition/active types=] is |resolvedRule|.

Note: the {{ViewTransition}} is skipped once the old document is hidden.

1. Set |outboundTransition|'s [=outbound post-capture steps=] to the following steps given a [=view transition params=]-or-null |params|:
1. Set |newDocument|'s [=inbound view transition params=] to |params|.

Expand Down