Use final and {} notation for array declarations.

Author: garydgregory

src/main/java/org/apache/commons/cli/Option.java

@@ -462,14 +462,14 @@ public Object clone() {
     }
 
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
         if (!(obj instanceof Option)) {
             return false;
         }
-        Option other = (Option) obj;
+        final Option other = (Option) obj;
         return Objects.equals(longOption, other.longOption) && Objects.equals(option, other.option);
     }
 

src/test/java/org/apache/commons/cli/DefaultParserTest.java

@@ -34,7 +34,7 @@ public void setUp() {
     @Override
     @Test
     public void testShortOptionConcatenatedQuoteHandling() throws Exception {
-        final String[] args = new String[] {"-b\"quoted string\""};
+        final String[] args = {"-b\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -45,7 +45,7 @@ public void testShortOptionConcatenatedQuoteHandling() throws Exception {
     @Override
     @Test
     public void testLongOptionWithEqualsQuoteHandling() throws Exception {
-        final String[] args = new String[] {"--bfile=\"quoted string\""};
+        final String[] args = {"--bfile=\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -55,7 +55,7 @@ public void testLongOptionWithEqualsQuoteHandling() throws Exception {
     @Test
     public void testShortOptionQuoteHandlingWithStrip() throws Exception {
         parser = DefaultParser.builder().setStripLeadingAndTrailingQuotes(true).build();
-        final String[] args = new String[] {"-b", "\"quoted string\""};
+        final String[] args = {"-b", "\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -65,7 +65,7 @@ public void testShortOptionQuoteHandlingWithStrip() throws Exception {
     @Test
     public void testShortOptionQuoteHandlingWithoutStrip() throws Exception {
         parser = DefaultParser.builder().setStripLeadingAndTrailingQuotes(false).build();
-        final String[] args = new String[] {"-b", "\"quoted string\""};
+        final String[] args = {"-b", "\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -75,7 +75,7 @@ public void testShortOptionQuoteHandlingWithoutStrip() throws Exception {
     @Test
     public void testLongOptionQuoteHandlingWithStrip() throws Exception {
         parser = DefaultParser.builder().setStripLeadingAndTrailingQuotes(true).build();
-        final String[] args = new String[] {"--bfile", "\"quoted string\""};
+        final String[] args = {"--bfile", "\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -85,7 +85,7 @@ public void testLongOptionQuoteHandlingWithStrip() throws Exception {
     @Test
     public void testLongOptionQuoteHandlingWithoutStrip() throws Exception {
         parser = DefaultParser.builder().setStripLeadingAndTrailingQuotes(false).build();
-        final String[] args = new String[] {"--bfile", "\"quoted string\""};
+        final String[] args = {"--bfile", "\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -95,7 +95,7 @@ public void testLongOptionQuoteHandlingWithoutStrip() throws Exception {
     @Test
     public void testLongOptionWithEqualsQuoteHandlingWithStrip() throws Exception {
         parser = DefaultParser.builder().setStripLeadingAndTrailingQuotes(true).build();
-        final String[] args = new String[] {"--bfile=\"quoted string\""};
+        final String[] args = {"--bfile=\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -105,7 +105,7 @@ public void testLongOptionWithEqualsQuoteHandlingWithStrip() throws Exception {
     @Test
     public void testLongOptionWithEqualsQuoteHandlingWithoutStrip() throws Exception {
         parser = DefaultParser.builder().setStripLeadingAndTrailingQuotes(false).build();
-        final String[] args = new String[] {"--bfile=\"quoted string\""};
+        final String[] args = {"--bfile=\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 

src/test/java/org/apache/commons/cli/ParserTestCase.java

@@ -957,7 +957,7 @@ public void testUnrecognizedOptionWithBursting() throws Exception {
 
     @Test
     public void testShortOptionQuoteHandling() throws Exception {
-        final String[] args = new String[] {"-b", "\"quoted string\""};
+        final String[] args = {"-b", "\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -966,7 +966,7 @@ public void testShortOptionQuoteHandling() throws Exception {
 
     @Test
     public void testLongOptionQuoteHandling() throws Exception {
-        final String[] args = new String[] {"--bfile", "\"quoted string\""};
+        final String[] args = {"--bfile", "\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -975,7 +975,7 @@ public void testLongOptionQuoteHandling() throws Exception {
 
     @Test
     public void testLongOptionWithEqualsQuoteHandling() throws Exception {
-        final String[] args = new String[] {"--bfile=\"quoted string\""};
+        final String[] args = {"--bfile=\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);
 
@@ -984,7 +984,7 @@ public void testLongOptionWithEqualsQuoteHandling() throws Exception {
 
     @Test
     public void testShortOptionConcatenatedQuoteHandling() throws Exception {
-        final String[] args = new String[] {"-b\"quoted string\""};
+        final String[] args = {"-b\"quoted string\""};
 
         final CommandLine cl = parser.parse(options, args);