Core: jQuery("#") is bad syntax

dmethvin · dmethvin · commit a0955cec123b · 2015-03-17T21:58:14.000-04:00
Fixes jquery#85 Closes jquery#95
diff --git a/src/core.js b/src/core.js
@@ -19,6 +19,7 @@ jQuery.fn.init = function( selector, context, rootjQuery ) {
 		if ( match[ 3 ] ) {
 			migrateWarn("$(html) HTML text after last tag is ignored");
 		}
+
 		// Consistently reject any HTML-like string starting with a hash (#9521)
 		// Note that this may break jQuery 1.6.x code that otherwise would work.
 		if ( match[ 0 ].charAt( 0 ) === "#" ) {
@@ -37,6 +38,12 @@ jQuery.fn.init = function( selector, context, rootjQuery ) {
 		}
 	}
 
+	// jQuery( "#" ) is a bogus ID selector, but it returned an empty set before jQuery 3.0
+	if ( selector === "#" ) {
+		migrateWarn( "jQuery( '#' ) is not a valid selector" );
+		selector = [];
+	}
+
 	ret = oldInit.apply( this, arguments );
 
 	// Fill in selector and context properties so .live() works
diff --git a/test/core.js b/test/core.js
@@ -47,6 +47,15 @@ test( "jQuery(html) loose rules", function() {
 	}
 });
 
+test( "jQuery( '#' )", function() {
+	expect( 2 );
+
+	expectWarning( "Selector, through the jQuery constructor, nothing but hash", function() {
+		var set = jQuery( "#" );
+		equal( set.length, 0, "empty set" );
+	});
+});
+
 test( "selector state", function() {
 	expect( 18 );
 

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ jQuery.fn.init = function( selector, context, rootjQuery ) {`
`19`	`19`	`if ( match[ 3 ] ) {`
`20`	`20`	`migrateWarn("$(html) HTML text after last tag is ignored");`
`21`	`21`	`}`
	`22`	`+`
`22`	`23`	`// Consistently reject any HTML-like string starting with a hash (#9521)`
`23`	`24`	`// Note that this may break jQuery 1.6.x code that otherwise would work.`
`24`	`25`	`if ( match[ 0 ].charAt( 0 ) === "#" ) {`
`@@ -37,6 +38,12 @@ jQuery.fn.init = function( selector, context, rootjQuery ) {`
`37`	`38`	`}`
`38`	`39`	`}`
`39`	`40`
	`41`	`+ // jQuery( "#" ) is a bogus ID selector, but it returned an empty set before jQuery 3.0`
	`42`	`+ if ( selector === "#" ) {`
	`43`	`+ migrateWarn( "jQuery( '#' ) is not a valid selector" );`
	`44`	`+ selector = [];`
	`45`	`+ }`
	`46`	`+`
`40`	`47`	`ret = oldInit.apply( this, arguments );`
`41`	`48`
`42`	`49`	`// Fill in selector and context properties so .live() works`