Skip to content

Commit 407b651

Browse files
refactor: stuff
1 parent ae37fd9 commit 407b651

23 files changed

+75
-882
lines changed

src/index.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,9 @@ export default function loader(content, map, meta) {
130130

131131
if (result.messages && result.messages.length > 0) {
132132
result.messages
133-
.filter((message) => (message.type === 'module' ? message : false))
133+
.filter(
134+
(message) => (message.type === 'css-loader' ? message : false)
135+
)
134136
.forEach((message) => {
135137
try {
136138
moduleObj = message.modify(moduleObj, this);

src/plugins/import.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ const parseImport = (params) => {
5858

5959
export default postcss.plugin(
6060
pluginName,
61-
(options) =>
61+
(options = {}) =>
6262
function process(css, result) {
6363
const { importLoaders } = options;
6464
const imports = {};
@@ -101,7 +101,7 @@ export default postcss.plugin(
101101

102102
result.messages.push({
103103
pluginName,
104-
type: 'module',
104+
type: 'css-loader',
105105
modify(moduleObj, loaderContext) {
106106
const { url, media } = importee;
107107

src/plugins/url.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ export default postcss.plugin(
117117
Object.keys(urls).forEach((url) => {
118118
result.messages.push({
119119
pluginName,
120-
type: 'module',
120+
type: 'css-loader',
121121
modify(moduleObj, loaderContext) {
122122
if (!hasURLEscapeRuntime) {
123123
moduleObj.imports.push(
@@ -139,6 +139,7 @@ export default postcss.plugin(
139139
urlToRequest(normalizedUrl)
140140
)}));`
141141
);
142+
// eslint-disable-next-line no-param-reassign
142143
moduleObj.module = moduleObj.module.replace(
143144
new RegExp(placeholder, 'g'),
144145
`" + ${placeholder} + "`

test/__snapshots__/import-option.test.js.snap

+5-12
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ exports[`import false: module (evaluated) 1`] = `
66
Array [
77
Array [
88
1,
9-
"
10-
@import url(test.css);
9+
"@import url(test.css);
1110
@import url('test.css');
1211
@import url(\\"test.css\\");
1312
@IMPORT url(test.css);
@@ -56,9 +55,8 @@ exports[`import false: module 1`] = `
5655
"// CSS runtime
5756
module.exports = exports = require(\\"../../../src/runtime/api.js\\")(false);
5857
59-
6058
// CSS module
61-
exports.push([module.id, \\"\\\\n@import url(test.css);\\\\n@import url('test.css');\\\\n@import url(\\\\\\"test.css\\\\\\");\\\\n@IMPORT url(test.css);\\\\n@import URL(test.css);\\\\n@import url();\\\\n@import url('');\\\\n@import url(\\\\\\"\\\\\\");\\\\n@import \\\\\\"test.css\\\\\\";\\\\n@import '';\\\\n@import \\\\\\"\\\\\\";\\\\n@import \\\\\\" \\\\\\";\\\\n@import url();\\\\n@import url('');\\\\n@import url(\\\\\\"\\\\\\");\\\\n@import url(test.css) screen and print;\\\\n@import url(test.css) SCREEN AND PRINT;\\\\n@import url(test.css)screen and print;\\\\n@import url(test-media.css) screen and print;\\\\n@import url(test-other.css) (min-width: 100px);\\\\n@import url(http://example.com/style.css);\\\\n@import url(http://example.com/style.css#hash);\\\\n@import url(http://example.com/other-style.css) screen and print;\\\\n@import url(\\\\\\"//example.com/style.css\\\\\\");\\\\n@import url(~package/test.css);\\\\n@import ;\\\\n@import foo-bar;\\\\n@import-normalize;\\\\n@import url('http://') :root {}\\\\n@import url('query.css?foo=1&bar=1');\\\\n@import url('other-query.css?foo=1&bar=1#hash');\\\\n\\\\n.class {\\\\n a: b c d;\\\\n}\\\\n\\\\n.foo {\\\\n @import 'path.css';\\\\n}\\\\n\\", \\"\\"]);
59+
exports.push([module.id, \\"@import url(test.css);\\\\n@import url('test.css');\\\\n@import url(\\\\\\"test.css\\\\\\");\\\\n@IMPORT url(test.css);\\\\n@import URL(test.css);\\\\n@import url();\\\\n@import url('');\\\\n@import url(\\\\\\"\\\\\\");\\\\n@import \\\\\\"test.css\\\\\\";\\\\n@import '';\\\\n@import \\\\\\"\\\\\\";\\\\n@import \\\\\\" \\\\\\";\\\\n@import url();\\\\n@import url('');\\\\n@import url(\\\\\\"\\\\\\");\\\\n@import url(test.css) screen and print;\\\\n@import url(test.css) SCREEN AND PRINT;\\\\n@import url(test.css)screen and print;\\\\n@import url(test-media.css) screen and print;\\\\n@import url(test-other.css) (min-width: 100px);\\\\n@import url(http://example.com/style.css);\\\\n@import url(http://example.com/style.css#hash);\\\\n@import url(http://example.com/other-style.css) screen and print;\\\\n@import url(\\\\\\"//example.com/style.css\\\\\\");\\\\n@import url(~package/test.css);\\\\n@import ;\\\\n@import foo-bar;\\\\n@import-normalize;\\\\n@import url('http://') :root {}\\\\n@import url('query.css?foo=1&bar=1');\\\\n@import url('other-query.css?foo=1&bar=1#hash');\\\\n\\\\n.class {\\\\n a: b c d;\\\\n}\\\\n\\\\n.foo {\\\\n @import 'path.css';\\\\n}\\\\n\\", \\"\\"]);
6260
"
6361
`;
6462

@@ -94,9 +92,7 @@ Array [
9492
],
9593
Array [
9694
4,
97-
"
98-
99-
.test {
95+
".test {
10096
c: d;
10197
}
10298
",
@@ -148,8 +144,7 @@ Array [
148144
],
149145
Array [
150146
1,
151-
"
152-
@import url();
147+
"@import url();
153148
@import url('');
154149
@import url(\\"\\");
155150
@import '';
@@ -179,7 +174,6 @@ Array [
179174
exports[`import true: module 1`] = `
180175
"// CSS runtime
181176
module.exports = exports = require(\\"../../../src/runtime/api.js\\")(false);
182-
183177
// CSS imports
184178
exports.i(require(\\"-!../../../src/index.js??ref--4!./test.css\\"), \\"\\");
185179
exports.i(require(\\"-!../../../src/index.js??ref--4!./test.css\\"), \\"screen and print\\");
@@ -192,9 +186,8 @@ exports.push([module.id, \\"@import url(//example.com/style.css);\\", \\"\\"]);
192186
exports.i(require(\\"-!../../../src/index.js??ref--4!package/test.css\\"), \\"\\");
193187
exports.i(require(\\"-!../../../src/index.js??ref--4!./query.css?foo=1&bar=1\\"), \\"\\");
194188
exports.i(require(\\"-!../../../src/index.js??ref--4!./other-query.css?foo=1&bar=1\\"), \\"\\");
195-
196189
// CSS module
197-
exports.push([module.id, \\"\\\\n@import url();\\\\n@import url('');\\\\n@import url(\\\\\\"\\\\\\");\\\\n@import '';\\\\n@import \\\\\\"\\\\\\";\\\\n@import \\\\\\" \\\\\\";\\\\n@import url();\\\\n@import url('');\\\\n@import url(\\\\\\"\\\\\\");\\\\n@import ;\\\\n@import foo-bar;\\\\n@import-normalize;\\\\n@import url('http://') :root {}\\\\n\\\\n.class {\\\\n a: b c d;\\\\n}\\\\n\\\\n.foo {\\\\n @import 'path.css';\\\\n}\\\\n\\", \\"\\"]);
190+
exports.push([module.id, \\"@import url();\\\\n@import url('');\\\\n@import url(\\\\\\"\\\\\\");\\\\n@import '';\\\\n@import \\\\\\"\\\\\\";\\\\n@import \\\\\\" \\\\\\";\\\\n@import url();\\\\n@import url('');\\\\n@import url(\\\\\\"\\\\\\");\\\\n@import ;\\\\n@import foo-bar;\\\\n@import-normalize;\\\\n@import url('http://') :root {}\\\\n\\\\n.class {\\\\n a: b c d;\\\\n}\\\\n\\\\n.foo {\\\\n @import 'path.css';\\\\n}\\\\n\\", \\"\\"]);
198191
"
199192
`;
200193

0 commit comments

Comments
 (0)