refactor: module

Author: alexander-akait

src/index.js

@@ -22,7 +22,6 @@ import {
   getImportPrefix,
   getFilter,
   getImportCode,
-  getModuleCode,
   getExportType,
   prepareCode,
 } from './utils';
@@ -129,8 +128,6 @@ export default function loader(content, map, meta) {
         importPrefix,
       };
 
-      const importCode = getImportCode(buildInfo);
-      const moduleCode = getModuleCode(buildInfo);
       const exportItems = result.messages
         .filter((message) => (message.type === 'export' ? message : false))
         .reduce((accumulator, currentValue) => {
@@ -139,27 +136,28 @@ export default function loader(content, map, meta) {
           return accumulator;
         }, []);
 
-      const code = [
-        // API
+      const importCode = getImportCode(buildInfo);
+      const moduleCode = !onlyLocals
+        ? `exports.push([module.id, ${JSON.stringify(result.css)}, ""${
+            sourceMap && result.map ? `,${result.map}` : ''
+          }]);\n`
+        : '';
+      const exportCode =
+        exportItems.length > 0
+          ? `${getExportType(onlyLocals)} = {\n${exportItems.join(',\n')}\n};`
+          : false;
+      const apiCode =
         importCode.length > 0 || moduleCode.length > 0
           ? `exports = module.exports = require(${stringifyRequest(
               this,
               require.resolve('./runtime/api')
             )})(${sourceMap});\n`
-          : false,
-        // Imports
-        importCode,
-        // Code
-        moduleCode,
-        // Exports
-        exportItems.length > 0
-          ? `${getExportType(onlyLocals)} = {\n${exportItems.join(',\n')}\n};`
-          : false,
-      ]
-        .filter(Boolean)
-        .join('');
+          : false;
 
-      return callback(null, prepareCode(buildInfo, code));
+      return callback(
+        null,
+        prepareCode({ apiCode, importCode, moduleCode, exportCode }, buildInfo)
+      );
     })
     .catch((error) => {
       callback(

src/utils.js

@@ -238,74 +238,73 @@ function getImportCode(buildInfo) {
   return importItems.length > 0 ? `${importItems.join('\n')}\n` : '';
 }
 
-function getModuleCode(buildInfo) {
-  const { onlyLocals } = buildInfo;
-
-  if (onlyLocals) {
-    return '';
-  }
+function getExportType(onlyLocals) {
+  return onlyLocals ? 'module.exports' : 'exports.locals';
+}
 
-  const moduleItems = [];
+function getIcssReplacer(item, buildInfo) {
+  const { importPrefix, onlyLocals, loaderContext } = buildInfo;
+  const importUrl = importPrefix + urlToRequest(item.url);
 
-  const { result, sourceMap } = buildInfo;
+  return () =>
+    onlyLocals
+      ? `" + require(${stringifyRequest(
+          loaderContext,
+          importUrl
+        )})[${JSON.stringify(item.export)}] + "`
+      : `" + require(${stringifyRequest(
+          loaderContext,
+          importUrl
+        )}).locals[${JSON.stringify(item.export)}] + "`;
+}
 
-  let cssAsString = JSON.stringify(result.css);
+function prepareCode(file, buildInfo) {
+  const { apiCode, importCode } = file;
+  let { moduleCode, exportCode } = file;
+  const { result } = buildInfo;
 
   result.messages
     .filter(
-      (message) =>
-        message.pluginName === 'postcss-url-parser' && message.type === 'url'
+      (message) => message.type === 'icss-import' || message.type === 'url'
     )
     .forEach((message) => {
-      const { placeholder } = message.item;
-
-      cssAsString = cssAsString.replace(
-        new RegExp(placeholder, 'g'),
-        () => `" + ${placeholder} + "`
-      );
-    });
-
-  moduleItems.push(
-    `exports.push([module.id, ${cssAsString}, ""${
-      sourceMap && result.map ? `,${result.map}` : ''
-    }]);`
-  );
+      // Replace all urls on `require`
+      if (message.type === 'url') {
+        const { placeholder } = message.item;
 
-  return moduleItems.length > 0 ? `${moduleItems.join('\n')}\n` : '';
-}
+        if (moduleCode) {
+          // eslint-disable-next-line no-param-reassign
+          moduleCode = moduleCode.replace(
+            new RegExp(placeholder, 'g'),
+            () => `" + ${placeholder} + "`
+          );
+        }
+      }
 
-function getExportType(onlyLocals) {
-  return onlyLocals ? 'module.exports' : 'exports.locals';
-}
+      // Replace external ICSS import on `require`
+      if (message.type === 'icss-import') {
+        const { item } = message;
+        const replacer = getIcssReplacer(item, buildInfo);
 
-function prepareCode(buildInfo, code) {
-  const { result, importPrefix, onlyLocals, loaderContext } = buildInfo;
+        if (moduleCode) {
+          // eslint-disable-next-line no-param-reassign
+          moduleCode = moduleCode.replace(
+            new RegExp(`___CSS_LOADER_IMPORT___(${item.index})___`, 'g'),
+            replacer
+          );
+        }
 
-  // replace external ICSS import on `require`
-  result.messages
-    .filter((message) => message.type === 'icss-import')
-    .forEach((message) => {
-      const { item } = message;
-      const importUrl = importPrefix + urlToRequest(item.url);
-
-      // eslint-disable-next-line no-param-reassign
-      code = code.replace(
-        new RegExp(`___CSS_LOADER_IMPORT___(${item.index})___`, 'g'),
-        () => {
-          return onlyLocals
-            ? `" + require(${stringifyRequest(
-                loaderContext,
-                importUrl
-              )})[${JSON.stringify(item.export)}] + "`
-            : `" + require(${stringifyRequest(
-                loaderContext,
-                importUrl
-              )}).locals[${JSON.stringify(item.export)}] + "`;
+        if (exportCode) {
+          // eslint-disable-next-line no-param-reassign
+          exportCode = exportCode.replace(
+            new RegExp(`___CSS_LOADER_IMPORT___(${item.index})___`, 'g'),
+            replacer
+          );
         }
-      );
+      }
     });
 
-  return code;
+  return [apiCode, importCode, moduleCode, exportCode].filter(Boolean).join('');
 }
 
 export {
@@ -315,7 +314,6 @@ export {
   getModulesPlugins,
   normalizeSourceMap,
   getImportCode,
-  getModuleCode,
   getExportType,
   prepareCode,
 };