Skip to content

Doesn't handle certain class names #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
necolas opened this issue Jun 7, 2015 · 2 comments
Closed

Doesn't handle certain class names #72

necolas opened this issue Jun 7, 2015 · 2 comments

Comments

@necolas
Copy link

necolas commented Jun 7, 2015

It should respect escaped characters in CSS.

Source:

/* can be used in html as "some:selector" */
.some\:selector { ... }

Expected:

._aHash { ... }

Actual:

._aHash\:selector { ... }
@necolas
Copy link
Author

necolas commented Jun 10, 2015

For more context. In https://github.com/necolas/react-web-sdk I'd like to rely on this working:

import styles from './styles.css';

styles['width:100%'];
=> <correct-selector-hash>

But at the moment :, %, and # are not handled properly when they are escaped in the CSS selector.

@necolas
Copy link
Author

necolas commented Jun 20, 2015

Thanks, this issue was fixed in 0.15.1 with the use of https://github.com/css-modules/css-selector-tokenizer/

@necolas necolas closed this as completed Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant