-
-
Notifications
You must be signed in to change notification settings - Fork 608
Find a way to reuse postcss instance #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm not sure if I would like to expose the PostCSS stuff from the css-loader. It's an implenentation detail. It's propably not a big performance issue... is it? |
Not sure it's a big one, but if we can avoid that... |
it's a great idea, especially thanks to postcss that we can use the many plugins, including cssnext. 👍 |
This would expose it. For now I'll keep it hidden. So you need the postcss-loader in addition to the css-loader for postcss plugins. That isn't so complex or inperformant. |
What are you afraid of ? |
Indeed it's not complex. But that would be a sweet possible optimisation. And there is no small optimisation, there is just optimisations ^^ |
I agree with @sokra. PostCSS shouldn't be exposed as part of the public API. It's private implementation detail that we might want to move away from in the future. Allowing users to couple themselves to our internal technology choices makes it harder for us to manage change effectively going forwards. |
Since you switched to postcss that would be nice to be able to use some plugins (like for example cssnext) via your module instead of duplicate parsing via another loader.
Are you open to that kind of enhancement ? That should not be a big deal to handle that right ?
The text was updated successfully, but these errors were encountered: