Skip to content

refactor: url and import option #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2021
Merged

refactor: url and import option #1299

merged 2 commits into from
May 1, 2021

Conversation

cap-Bernardito
Copy link
Member

@cap-Bernardito cap-Bernardito commented May 1, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Reducing the number of options, bringing them to a single view

Breaking Changes

  • Type function for url options replaced by an object with a filter key
  • Type function for import options replaced by an object with a filter key

Additional Info

No

Base automatically changed from feat-new-url to next May 1, 2021 13:56
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #1299 (6c8b902) into next (e9ac2f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1299   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          11       11           
  Lines         845      845           
  Branches      285      285           
=======================================
  Hits          830      830           
  Misses         12       12           
  Partials        3        3           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ac2f3...6c8b902. Read the comment docs.

@cap-Bernardito cap-Bernardito changed the title refactor: url option refactor: url and import option May 1, 2021
@alexander-akait alexander-akait merged commit 2f37484 into next May 1, 2021
@alexander-akait alexander-akait deleted the refactor-url branch May 1, 2021 15:33
cap-Bernardito added a commit that referenced this pull request Jun 28, 2021
cap-Bernardito added a commit that referenced this pull request Jun 28, 2021
cap-Bernardito added a commit that referenced this pull request Jul 13, 2021
cap-Bernardito added a commit that referenced this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants