Skip to content

Conversation

@danielroe
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The current documentation suggests that url can be set to an object with url as a property, whereas this should be filter

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 17, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: danielroe / name: Daniel Roe (2f4de5d)

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1430 (2f4de5d) into master (830fe2c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1430   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          12       12           
  Lines        1131     1131           
  Branches      411      411           
=======================================
  Hits         1095     1095           
  Misses         27       27           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830fe2c...2f4de5d. Read the comment docs.

@alexander-akait alexander-akait merged commit 423ab86 into webpack:master Mar 17, 2022
@danielroe danielroe deleted the patch-1 branch March 17, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants