refactor: remove reloadAll option

Author: cap-Bernardito

README.md

@@ -404,10 +404,6 @@ The `mini-css-extract-plugin` supports hot reloading of actual css files in deve
 Some options are provided to enable HMR of both standard stylesheets and locally scoped CSS or CSS modules.
 Below is an example configuration of mini-css for HMR use with CSS modules.
 
-While we attempt to hmr css-modules. It is not easy to perform when code-splitting with custom chunk names.
-`reloadAll` is an option that should only be enabled if HMR isn't working correctly.
-The core challenge with css-modules is that when code-split, the chunk ids can and do end up different compared to the filename.
-
 You should not use `HotModuleReplacementPlugin` plugin if you are using a `webpack-dev-server`.
 `webpack-dev-server` enables / disables HMR using `hot` option.
 
@@ -439,10 +435,7 @@ module.exports = {
         use: [
           {
             loader: MiniCssExtractPlugin.loader,
-            options: {
-              // if hmr does not work, this is a forceful method.
-              reloadAll: true,
-            },
+            options: {},
           },
           'css-loader',
         ],

src/hmr/hotModuleReplacement.js

@@ -216,7 +216,7 @@ module.exports = function (moduleId, options) {
       return;
     }
 
-    if (reloaded && !options.reloadAll) {
+    if (reloaded) {
       console.log('[HMR] css reload %s', src.join(' '));
     } else {
       console.log('[HMR] Reload all css');

src/loader-options.json

@@ -18,9 +18,6 @@
     "hmr": {
       "type": "boolean"
     },
-    "reloadAll": {
-      "type": "boolean"
-    },
     "modules": {
       "type": "object",
       "additionalProperties": false,

test/HMR.test.js

@@ -126,31 +126,6 @@ describe('HMR', () => {
     }, 100);
   });
 
-  it('should reloads with reloadAll option', (done) => {
-    const update = hotModuleReplacement('./src/style.css', {
-      reloadAll: true,
-    });
-
-    update();
-
-    setTimeout(() => {
-      expect(console.log.mock.calls[0][0]).toMatchSnapshot();
-
-      const links = Array.prototype.slice.call(
-        document.querySelectorAll('link')
-      );
-
-      expect(links[0].visited).toBe(true);
-      expect(document.head.innerHTML).toMatchSnapshot();
-
-      links[1].dispatchEvent(getLoadEvent());
-
-      expect(links[1].isLoaded).toBe(true);
-
-      done();
-    }, 100);
-  });
-
   it('should reloads with non http/https link href', (done) => {
     document.head.innerHTML =
       '<link rel="stylesheet" href="/dist/main.css" /><link rel="shortcut icon" href="data:;base64,=" />';

test/__snapshots__/HMR.test.js.snap

@@ -24,10 +24,6 @@ exports[`HMR should reloads with non http/https link href 1`] = `"[HMR] css relo
 
 exports[`HMR should reloads with non http/https link href 2`] = `"<link rel=\\"stylesheet\\" href=\\"/dist/main.css\\"><link rel=\\"stylesheet\\" href=\\"http://localhost/dist/main.css?1479427200000\\"><link rel=\\"shortcut icon\\" href=\\"data:;base64,=\\">"`;
 
-exports[`HMR should reloads with reloadAll option 1`] = `"[HMR] Reload all css"`;
-
-exports[`HMR should reloads with reloadAll option 2`] = `"<link rel=\\"stylesheet\\" href=\\"/dist/main.css\\"><link rel=\\"stylesheet\\" href=\\"http://localhost/dist/main.css?1479427200000\\">"`;
-
 exports[`HMR should works 1`] = `"[HMR] css reload %s"`;
 
 exports[`HMR should works 2`] = `"<link rel=\\"stylesheet\\" href=\\"/dist/main.css\\"><link rel=\\"stylesheet\\" href=\\"http://localhost/dist/main.css?1479427200000\\">"`;

test/__snapshots__/validate-loader-options.test.js.snap

@@ -36,10 +36,3 @@ options.publicPath should pass \\"instanceof\\" keyword validation
 options.publicPath should match some schema in anyOf
 "
 `;
-
-exports[`validate options should throw an error on the "reloadAll" option with "1" value 1`] = `
-"Mini CSS Extract Plugin Loader Invalid Options
-
-options.reloadAll should be boolean
-"
-`;

test/cases/hmr/expected/webpack-4/main.js

@@ -1092,7 +1092,7 @@ module.exports = function (moduleId, options) {
       return;
     }
 
-    if (reloaded && !options.reloadAll) {
+    if (reloaded) {
       console.log('[HMR] css reload %s', src.join(' '));
     } else {
       console.log('[HMR] Reload all css');

test/cases/hmr/expected/webpack-5/main.js

@@ -234,7 +234,7 @@ module.exports = function (moduleId, options) {
       return;
     }
 
-    if (reloaded && !options.reloadAll) {
+    if (reloaded) {
       console.log('[HMR] css reload %s', src.join(' '));
     } else {
       console.log('[HMR] Reload all css');

test/manual/src/index.js

@@ -34,6 +34,7 @@ if (module.hot) {
       replaceClass(localClass, classes[localClass]);
     });
     oldClasses = classes;
+    // eslint-disable-next-line no-alert
     alert('HMR updated CSS module');
   });
 }

test/validate-loader-options.test.js

@@ -14,10 +14,6 @@ describe('validate options', () => {
       success: [true, false],
       failure: [1],
     },
-    reloadAll: {
-      success: [true, false],
-      failure: [1],
-    },
     modules: {
       success: [{ namedExport: true }, { namedExport: false }],
       failure: ['true', { namedExport: 'false' }],