Skip to content

Error type not propagated #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbedard opened this issue May 17, 2018 · 2 comments · Fixed by #651
Closed

Error type not propagated #152

jbedard opened this issue May 17, 2018 · 2 comments · Fixed by #651
Labels
good first pr help wanted priority: 3 (important) severity: 4 (inconvenient) type: bug
Milestone
0.5.0

Comments

@jbedard
Copy link

jbedard commented May 17, 2018 •
edited
Loading

The webpack script loading error handling propagates the Error.type: https://github.com/webpack/webpack/blob/v4.8.3/lib/web/JsonpMainTemplatePlugin.js#L187-L192

Would be nice if the same was done for the css <link> load errors: https://github.com/webpack-contrib/mini-css-extract-plugin/blob/v0.4.0/src/index.js#L303-L309
@smartthingstutor

This comment has been minimized.

Sign in to view
@alexander-akait
Copy link
Member

PR welcome

@michael-ciniawsky michael-ciniawsky added this to the 0.5.0 milestone Aug 24, 2018
@alexander-akait alexander-akait mentioned this issue Nov 6, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first pr help wanted priority: 3 (important) severity: 4 (inconvenient) type: bug
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

feat: added the type property for loading errors webpack-contrib/mini-css-extract-plugin
4 participants
@jbedard @alexander-akait @michael-ciniawsky @smartthingstutor