From c7e72ff281601afe8c9b03cafb296b41080ea089 Mon Sep 17 00:00:00 2001 From: "alexander.akait" Date: Tue, 29 Nov 2022 20:17:49 +0300 Subject: [PATCH 1/2] refactor: fix compatibility with old browsers --- src/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index 069ac721..4eb14b1a 100644 --- a/src/index.js +++ b/src/index.js @@ -888,7 +888,9 @@ class MiniCssExtractPlugin { ]) : Template.asString([ "if (oldTag) {", - Template.indent(["oldTag.after(linkTag);"]), + Template.indent([ + "oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling);", + ]), "} else {", Template.indent(["document.head.appendChild(linkTag);"]), "}", From 3f1fa7ef146a02dff6f61f77630a614e02e0565f Mon Sep 17 00:00:00 2001 From: "alexander.akait" Date: Tue, 29 Nov 2022 20:33:40 +0300 Subject: [PATCH 2/2] test: update --- ...{0.32c982869d9446e21cfa.css => 0.945622d4f51f3fe3a0d0.css} | 0 .../{32c982869d9446e21cfa.css => 945622d4f51f3fe3a0d0.css} | 0 .../expected/webpack-5-importModule/main.js | 4 ++-- ...{0.70641d5edcf4cb37424c.css => 0.de494c1e7411c41d8362.css} | 0 .../{70641d5edcf4cb37424c.css => de494c1e7411c41d8362.css} | 0 test/cases/chunkFilename-fullhash/expected/webpack-5/main.js | 4 ++-- test/cases/hmr/expected/main.js | 2 +- test/cases/insert-undefined/expected/main.js | 2 +- 8 files changed, 6 insertions(+), 6 deletions(-) rename test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/{0.32c982869d9446e21cfa.css => 0.945622d4f51f3fe3a0d0.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/{32c982869d9446e21cfa.css => 945622d4f51f3fe3a0d0.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5/{0.70641d5edcf4cb37424c.css => 0.de494c1e7411c41d8362.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5/{70641d5edcf4cb37424c.css => de494c1e7411c41d8362.css} (100%) diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.32c982869d9446e21cfa.css b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.945622d4f51f3fe3a0d0.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.32c982869d9446e21cfa.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.945622d4f51f3fe3a0d0.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/32c982869d9446e21cfa.css b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/945622d4f51f3fe3a0d0.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/32c982869d9446e21cfa.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/945622d4f51f3fe3a0d0.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js index 6acd31cc..8c4d255c 100644 --- a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js +++ b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__); /******/ /******/ /* webpack/runtime/getFullHash */ /******/ (() => { -/******/ __webpack_require__.h = () => ("32c982869d9446e21cfa") +/******/ __webpack_require__.h = () => ("945622d4f51f3fe3a0d0") /******/ })(); /******/ /******/ /* webpack/runtime/global */ @@ -196,7 +196,7 @@ __webpack_require__.r(__webpack_exports__); /******/ linkTag.href = fullhref; /******/ /******/ if (oldTag) { -/******/ oldTag.after(linkTag); +/******/ oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling); /******/ } else { /******/ document.head.appendChild(linkTag); /******/ } diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/0.70641d5edcf4cb37424c.css b/test/cases/chunkFilename-fullhash/expected/webpack-5/0.de494c1e7411c41d8362.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5/0.70641d5edcf4cb37424c.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5/0.de494c1e7411c41d8362.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/70641d5edcf4cb37424c.css b/test/cases/chunkFilename-fullhash/expected/webpack-5/de494c1e7411c41d8362.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5/70641d5edcf4cb37424c.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5/de494c1e7411c41d8362.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js index 58994c6c..9cbf1619 100644 --- a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js +++ b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__); /******/ /******/ /* webpack/runtime/getFullHash */ /******/ (() => { -/******/ __webpack_require__.h = () => ("70641d5edcf4cb37424c") +/******/ __webpack_require__.h = () => ("de494c1e7411c41d8362") /******/ })(); /******/ /******/ /* webpack/runtime/global */ @@ -196,7 +196,7 @@ __webpack_require__.r(__webpack_exports__); /******/ linkTag.href = fullhref; /******/ /******/ if (oldTag) { -/******/ oldTag.after(linkTag); +/******/ oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling); /******/ } else { /******/ document.head.appendChild(linkTag); /******/ } diff --git a/test/cases/hmr/expected/main.js b/test/cases/hmr/expected/main.js index ee4a6f9f..eebf4011 100644 --- a/test/cases/hmr/expected/main.js +++ b/test/cases/hmr/expected/main.js @@ -959,7 +959,7 @@ __webpack_require__.r(__webpack_exports__); /******/ linkTag.href = fullhref; /******/ /******/ if (oldTag) { -/******/ oldTag.after(linkTag); +/******/ oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling); /******/ } else { /******/ document.head.appendChild(linkTag); /******/ } diff --git a/test/cases/insert-undefined/expected/main.js b/test/cases/insert-undefined/expected/main.js index 06940274..907e94ad 100644 --- a/test/cases/insert-undefined/expected/main.js +++ b/test/cases/insert-undefined/expected/main.js @@ -180,7 +180,7 @@ /******/ linkTag.href = fullhref; /******/ /******/ if (oldTag) { -/******/ oldTag.after(linkTag); +/******/ oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling); /******/ } else { /******/ document.head.appendChild(linkTag); /******/ }