Skip to content

Commit 1629b70

Browse files
fix: handle errors from child compilations
1 parent 62fbad9 commit 1629b70

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/loader.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -351,14 +351,6 @@ export function pitch(request) {
351351
}
352352

353353
childCompiler.runAsChild((error, entries, compilation) => {
354-
const assets = Object.create(null);
355-
const assetsInfo = new Map();
356-
357-
for (const asset of compilation.getAssets()) {
358-
assets[asset.name] = asset.source;
359-
assetsInfo.set(asset.name, asset.info);
360-
}
361-
362354
if (error) {
363355
return callback(error);
364356
}
@@ -367,6 +359,14 @@ export function pitch(request) {
367359
return callback(compilation.errors[0]);
368360
}
369361

362+
const assets = Object.create(null);
363+
const assetsInfo = new Map();
364+
365+
for (const asset of compilation.getAssets()) {
366+
assets[asset.name] = asset.source;
367+
assetsInfo.set(asset.name, asset.info);
368+
}
369+
370370
compilation.fileDependencies.forEach((dep) => {
371371
this.addDependency(dep);
372372
}, this);

0 commit comments

Comments
 (0)