8000 fix: issue 701 by cap-Bernardito · Pull Request #702 · webpack/mini-css-extract-plugin · GitHub
Skip to content

fix: issue 701 #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 7 commits into from
Feb 18, 2021
Merged

fix: issue 701 #702

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0997a13
fix: issue 701
cap-Bernardito Feb 17, 2021
013360d
fix: issue 701
cap-Bernardito Feb 17, 2021
f76c0a6
fix: improves sorting of modules
cap-Bernardito Feb 18, 2021
1882c24
fix: improves sorting of modules
cap-Bernardito Feb 18, 2021
acd6825
fix: improves sorting of modules
cap-Bernardito Feb 18, 2021
c5ba6d7
fix: improves sorting of modules
cap-Bernardito Feb 18, 2021
c3eb08b
fix: improves sorting of modules
cap-Bernardito Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: improves sorting of modules
  • Loading branch information
@cap-Bernardito
cap-Bernardito committed Feb 18, 2021
commit acd68250399a77aebc65a14266fec0849e15e784
28 changes: 17 additions & 11 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,13 @@ class MiniCssExtractPlugin {
sortedModules(compilation, chunk, modules, requestShortener) {
let cache = this._sortedModulesCache.get(chunk);

if (!cache) {
cache = this.sortModules(compilation, chunk, modules, requestShortener);
if (!cache && modules) {
cache = this.sortModules(
compilation,
chunk,
[...modules],
requestShortener
);
this._sortedModulesCache.set(chunk, cache);
}

Expand Down Expand Up @@ -544,20 +549,21 @@ class MiniCssExtractPlugin {

compilation.hooks.contentHash.tap(pluginName, (chunk) => {
const { outputOptions, chunkGraph } = compilation;
let modules = isWebpack4
const modules = isWebpack4
? Array.from(this.getChunkModules(chunk, chunkGraph)).filter(
(module) => module.type === MODULE_TYPE
)
: chunkGraph.getChunkModulesIterableBySourceType(chunk, MODULE_TYPE);
: this.sortedModules(
compilation,
chunk,
chunkGraph.getChunkModulesIterableBySourceType(
chunk,
MODULE_TYPE
),
compilation.runtimeTemplate.requestShortener
);

if (modules) {
modules = this.sortedModules(
compilation,
chunk,
[...modules],
compilation.runtimeTemplate.requestShortener
);

const { hashFunction, hashDigest, hashDigestLength } = outputOptions;
const createHash = compiler.webpack
? compiler.webpack.util.createHash
Expand Down