tests: Don't use ReflectionMethod::setAccessible(), it's a no-op now

reedy · reedy · commit 6da71c7f59aa · 2025-10-09T16:18:36.000+01:00
Bug: T406744
Change-Id: I2dadba34882ea45dad76e243dbbfc6e47e0de50c
diff --git a/tests/Sanitizer/RuleSanitizerTest.php b/tests/Sanitizer/RuleSanitizerTest.php
@@ -47,7 +47,6 @@ protected function getSanitizer( $options = [] ) {
 		}
 		if ( $method ) {
 			$rm = new ReflectionMethod( $san, $method );
-			$rm->setAccessible( true );
 			$san->method( 'doSanitize' )->willReturnCallback( static function ( $rule ) use ( $rm, $san, $arg ) {
 				$ret = clone $rule;
 				// @phan-suppress-next-line PhanPossiblyUndeclaredVariable $arg set when reaching this code

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ protected function getSanitizer( $options = [] ) {`
`47`	`47`	`}`
`48`	`48`	`if ( $method ) {`
`49`	`49`	`$rm = new ReflectionMethod( $san, $method );`
`50`		`- $rm->setAccessible( true );`
`51`	`50`	`$san->method( 'doSanitize' )->willReturnCallback( static function ( $rule ) use ( $rm, $san, $arg ) {`
`52`	`51`	`$ret = clone $rule;`
`53`	`52`	`// @phan-suppress-next-line PhanPossiblyUndeclaredVariable $arg set when reaching this code`