Use php8 functions str_contains and str_starts_with

For readability of the conditions

Change-Id: I5e872525185e8b32aa1d8db3872fed2a250e3670

Author: umherirrender

src/Objects/Token.php

@@ -420,7 +420,7 @@ public function __toString() {
 					$unit = '%';
 				} elseif ( $this->type === self::T_DIMENSION ) {
 					$unit = self::escapeIdent( $this->unit );
-					if ( strpos( $number, 'e' ) === false && strpos( $number, 'E' ) === false &&
+					if ( !str_contains( $number, 'e' ) && !str_contains( $number, 'E' ) &&
 						preg_match( '/^[eE][+-]?\d/', $unit )
 					) {
 						// Unit would look like exponential notation, so escape the leading "e"

src/Parser/Encoder.php

@@ -265,7 +265,7 @@ class Encoder {
 	 */
 	public static function convert( $text, $encodings = [] ) {
 		// First, check for a BOM and honor that if it's present.
-		if ( strpos( $text, "\xef\xbb\xbf" ) === 0 ) {
+		if ( str_starts_with( $text, "\xef\xbb\xbf" ) ) {
 			// UTF-8 with BOM (convert it anyway in case the BOM is a lie)
 			return self::doConvert( 'UTF-8', substr( $text, 3 ) );
 		}

tests/Grammar/TestMatcherFactory.php

@@ -31,7 +31,7 @@ public function urlstring( $type ) {
 		$key = __METHOD__ . ':' . $type;
 		if ( !isset( $this->cache[$key] ) ) {
 			$this->cache[$key] = new TokenMatcher( Token::T_STRING, static function ( $url ) use ( $type ) {
-				return strpos( $url, $type ) !== false;
+				return str_contains( $url, $type );
 			} );
 		}
 		return $this->cache[$key];
@@ -42,7 +42,7 @@ public function url( $type ) {
 		$key = __METHOD__ . ':' . $type;
 		if ( !isset( $this->cache[$key] ) ) {
 			$this->cache[$key] = new UrlMatcher( static function ( $url, $modifiers ) use ( $type ) {
-				return strpos( $url, $type ) !== false;
+				return str_contains( $url, $type );
 			}, [
 				'modifierMatcher' => new Alternative( [
 					new KeywordMatcher( [ 'x', 'y' ] ),