Fix: buffer replace issue

Author: seanmurrin

build/index.d.ts

@@ -1,6 +1,6 @@
-import { Compiler } from 'webpack';
+import { Compiler } from "webpack";
 interface ReplaceConfig {
-    position?: 'before' | 'after';
+    position?: "before" | "after";
     removeTarget?: boolean;
     target: string;
     leaveCssFile?: boolean;

build/index.js

@@ -1,57 +1,62 @@
-import { Compiler, Configuration } from 'webpack';
+import { Compiler, Configuration } from "webpack";
 
 type File = {
-  [key: string]: string
+  [key: string]: string;
 };
 
 type Asset = {
-  source(): string
-  size(): number
+  source(): string;
+  size(): number;
 };
 
 interface Compilation {
-  assets: { [key: string]: Asset }
+  assets: { [key: string]: Asset };
 }
 
 interface ReplaceConfig {
-  position?: 'before' | 'after'
-  removeTarget?: boolean
-  target: string,
-  leaveCssFile?: boolean
+  position?: "before" | "after";
+  removeTarget?: boolean;
+  target: string;
+  leaveCssFile?: boolean;
 }
 
 interface Config {
-  filter?(fileName: string): boolean
-  replace?: ReplaceConfig
+  filter?(fileName: string): boolean;
+  replace?: ReplaceConfig;
 }
 
 const DEFAULT_REPLACE_CONFIG: ReplaceConfig = {
-  target: '</head>'
+  target: "</head>"
 };
 
-export default class Plugin
-{
+export default class Plugin {
   static addStyle(html: string, style: string, replaceConfig: ReplaceConfig) {
     const styleString = `<style type="text/css">${style}</style>`;
     const replaceValues = [styleString, replaceConfig.target];
 
-    if (replaceConfig.position === 'after') {
-      replaceValues.reverse()
+    if (replaceConfig.position === "after") {
+      replaceValues.reverse();
     }
 
-    return html.replace(replaceConfig.target, replaceValues.join(''));
+    html = String(html);
+
+    return html.replace(replaceConfig.target, replaceValues.join(""));
   }
 
   static removeLinkTag(html: string, cssFileName: string) {
+    html = String(html);
+
     return html.replace(
       new RegExp(`<link[^>]+href=['"]${cssFileName}['"][^>]+(>|\/>|><\/link>)`),
-      '',
+      ""
     );
   }
 
   static cleanUp(html: string, replaceConfig: ReplaceConfig) {
+    html = String(html);
+
     return replaceConfig.removeTarget
-      ? html.replace(replaceConfig.target, '')
+      ? html.replace(replaceConfig.target, "")
       : html;
   }
 
@@ -62,25 +67,25 @@ export default class Plugin
   constructor(private readonly config: Config = {}) {}
 
   private filter(fileName: string): boolean {
-    if (typeof this.config.filter === 'function') {
+    if (typeof this.config.filter === "function") {
       return this.config.filter(fileName);
     } else {
       return true;
     }
   }
 
   private prepare({ assets }: Compilation) {
-    const isCSS = is('css');
-    const isHTML = is('html');
+    const isCSS = is("css");
+    const isHTML = is("html");
     const { replace: replaceConfig = DEFAULT_REPLACE_CONFIG } = this.config;
 
-    Object.keys(assets).forEach((fileName) => {
+    Object.keys(assets).forEach(fileName => {
       if (isCSS(fileName)) {
         const isCurrentFileNeedsToBeInlined = this.filter(fileName);
         if (isCurrentFileNeedsToBeInlined) {
           this.css[fileName] = assets[fileName].source();
           if (!replaceConfig.leaveCssFile) {
-            delete assets[fileName]
+            delete assets[fileName];
           }
         }
       } else if (isHTML(fileName)) {
@@ -90,32 +95,39 @@ export default class Plugin
   }
 
   private process({ assets }: Compilation, { output }: Configuration) {
-    const publicPath = (output && output.publicPath) || '';
+    const publicPath = (output && output.publicPath) || "";
     const { replace: replaceConfig = DEFAULT_REPLACE_CONFIG } = this.config;
 
-    Object.keys(this.html).forEach((htmlFileName) => {
+    Object.keys(this.html).forEach(htmlFileName => {
       let html = this.html[htmlFileName];
 
-      Object.keys(this.css).forEach((key) => {
+      Object.keys(this.css).forEach(key => {
         html = Plugin.addStyle(html, this.css[key], replaceConfig);
         html = Plugin.removeLinkTag(html, publicPath + key);
       });
 
       html = Plugin.cleanUp(html, replaceConfig);
 
       assets[htmlFileName] = {
-        source() { return html },
-        size() { return html.length },
+        source() {
+          return html;
+        },
+        size() {
+          return html.length;
+        }
       };
     });
   }
 
   apply(compiler: Compiler) {
-    compiler.hooks.emit.tapAsync('html-inline-css-webpack-plugin', (compilation: Compilation, callback: () => void) => {
-      this.prepare(compilation);
-      this.process(compilation, compiler.options);
-      callback();
-    });
+    compiler.hooks.emit.tapAsync(
+      "html-inline-css-webpack-plugin",
+      (compilation: Compilation, callback: () => void) => {
+        this.prepare(compilation);
+        this.process(compilation, compiler.options);
+        callback();
+      }
+    );
   }
 }