fix: review changes

Author: phoenisx

docs/customize-extension.md

@@ -16,7 +16,8 @@ The following list of source file extensions does not need any customization.
   - Statically parses [template literals](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals). No customization needed
 
 > `cssvar` has minimal support for parsing JS/TS files.
-> __*If you are facing issues with JS/TS source file parsing try*__
+> __*This won't be required, but in case you face issues with*__
+> __*JS/TS source file parsing try*__
 > __*using [postcss-css-in-js][css-in-js] parser,*__
 > __*as described in the [following section](#example-ii)*__.
 

examples/css-extensions/package.json

@@ -8,9 +8,5 @@
   },
   "keywords": [],
   "author": "",
-  "license": "ISC",
-  "dependencies": {
-    "postcss": "8",
-    "postcss-scss": "^4.0.4"
-  }
+  "license": "ISC"
 }

examples/css-extensions/pnpm-lock.yaml

@@ -223,32 +223,76 @@
             "postcss-sass": {
               "type": "array",
               "description": "Sass (.sass) source file extensions to parse",
-              "default": ["sass"],
-              "examples": [["sass"]]
+              "default": [
+                "sass"
+              ],
+              "examples": [
+                [
+                  "sass"
+                ]
+              ]
             },
             "postcss-html": {
               "type": "array",
               "description": "HTML (.html) source file extensions to parse",
-              "default": ["html"],
-              "examples": [["html", "ejs"]]
+              "default": [
+                "html"
+              ],
+              "examples": [
+                [
+                  "html",
+                  "ejs"
+                ]
+              ]
             },
             "sugarss": {
               "type": "array",
               "description": "SugarSS (.sss) source file extensions to parse",
-              "default": ["sss"],
-              "examples": [["sss"]]
+              "default": [
+                "sss"
+              ],
+              "examples": [
+                [
+                  "sss"
+                ]
+              ]
             },
             "postcss-styl": {
               "type": "array",
               "description": "Stylus (.styl) source file extensions to parse. Repo: https://github.com/stylus/postcss-styl",
-              "default": ["styl"],
-              "examples": [["styl"]]
+              "default": [
+                "styl"
+              ],
+              "examples": [
+                [
+                  "styl"
+                ]
+              ]
+            },
+            "postcss-syntax": {
+              "type": "array",
+              "description": "To parse template literals in JS/TS source files. Details: https://github.com/willofindie/vscode-cssvar/tree/main/docs/customize-extension.md",
+              "default": [],
+              "examples": [
+                [
+                  "js",
+                  "ts",
+                  "sass"
+                ]
+              ]
             },
             "postcss-lit": {
               "type": "array",
               "description": "To parse Lit templates in JS/TS source files. Repo: https://github.com/43081j/postcss-lit",
-              "default": ["ts"],
-              "examples": [["js", "ts"]]
+              "default": [
+                "ts"
+              ],
+              "examples": [
+                [
+                  "js",
+                  "ts"
+                ]
+              ]
             }
           },
           "additionalProperties": true,
@@ -307,8 +351,7 @@
     "culori": "^2.0.3",
     "fast-glob": "^3.2.11",
     "postcss": "^8.4.12",
-    "postcss-less": "^6.0.0",
-    "postcss-scss": "^4.0.4"
+    "postcss-less": "^6.0.0"
   },
   "lint-staged": {
     "*.{ts,tsx}": [

package.json

@@ -14,6 +14,7 @@ import { CssDefinitionProvider } from "./definition-provider";
 import { LOGGER } from "./logger";
 import { setup } from "./main";
 import { parseFiles } from "./parser";
+import { isObjectProperty } from "./utils";
 
 const watchers: FileSystemWatcher[] = [];
 
@@ -117,7 +118,7 @@ export function deactivate(): void {
  */
 function updateStatus(event: TextEditor | undefined) {
   if (event) {
-    if (Object.prototype.hasOwnProperty.call(event, "document")) {
+    if (isObjectProperty(event, "document")) {
       const rootPath =
         workspace.getWorkspaceFolder((<TextEditor>event).document.uri)?.uri
           .fsPath || CACHE.activeRootPath;

src/extension.ts

@@ -94,7 +94,7 @@ export async function setup(): Promise<{
             if (syntaxes) {
               config[fsPathKey][key] = Object.keys(syntaxes).reduce(
                 (syntaxMap, key) => {
-                  if (Object.prototype.hasOwnProperty.call(syntaxes, key)) {
+                  if (isObjectProperty(syntaxes, key)) {
                     const exts = syntaxes[key];
                     exts.forEach(ext => {
                       syntaxMap[ext] = key;

src/main.ts

@@ -297,9 +297,9 @@ export const getCSSErrorMsg = (
   error: Record<string, any>
 ) => {
   if (
-    Object.prototype.hasOwnProperty.call(error, "name") &&
-    Object.prototype.hasOwnProperty.call(error, "reason") &&
-    Object.prototype.hasOwnProperty.call(error, "line")
+    isObjectProperty(error, "name") &&
+    isObjectProperty(error, "reason") &&
+    isObjectProperty(error, "line")
   ) {
     return JSON.stringify(
       {

src/utils.ts

@@ -4461,11 +4461,6 @@ postcss-less@^6.0.0:
   resolved "https://registry.yarnpkg.com/postcss-less/-/postcss-less-6.0.0.tgz#463b34c60f53b648c237f569aeb2e09149d85af4"
   integrity sha512-FPX16mQLyEjLzEuuJtxA8X3ejDLNGGEG503d2YGZR5Ask1SpDN8KmZUMpzCvyalWRywAn1n1VOA5dcqfCLo5rg==
 
-postcss-scss@^4.0.4:
-  version "4.0.4"
-  resolved "https://registry.yarnpkg.com/postcss-scss/-/postcss-scss-4.0.4.tgz#aa8f60e19ee18259bc193db9e4b96edfce3f3b1f"
-  integrity sha512-aBBbVyzA8b3hUL0MGrpydxxXKXFZc5Eqva0Q3V9qsBOLEMsjb6w49WfpsoWzpEgcqJGW4t7Rio8WXVU9Gd8vWg==
-
 postcss@^8.1.2, postcss@^8.4.12, postcss@^8.4.4:
   version "8.4.14"
   resolved "https://registry.yarnpkg.com/postcss/-/postcss-8.4.14.tgz#ee9274d5622b4858c1007a74d76e42e56fd21caf"