Skip to content

Commit c64621e

Browse files
committed
Don't version .dev files; remove code in version task
The mechanism used to version these files is prone to error, because it does a global search and replace looking for the prior version and replacing it with the new version. If any versions have been skipped or any version number has been altered by hand, this won't work. The .dev files are not for release and so do not need to be versioned. The production files contain a banner which will automatically pull the right version number when the files are built.
1 parent 7da3b98 commit c64621e

21 files changed

+2
-35
lines changed

Gruntfile.js

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ module.exports = function (grunt) {
126126
});
127127

128128
/*
129-
* Change to new version or the next version number in all files
130-
* containing the version definition
129+
* Change to new version or the next version number. The project must be built again after this task
130+
* in order for the version change to take effect.
131131
*/
132132
grunt.registerTask('version', 'Bump up the version number, or change version name by adding --new-version=3.1.0', function () {
133133
var pkg = grunt.config.get('pkg'),
@@ -142,19 +142,6 @@ module.exports = function (grunt) {
142142
}
143143

144144
grunt.log.writeln('* Moving from version ' + currentVersion + ' to ' + newVersion);
145-
var fromVersion = '@version ' + currentVersion,
146-
toVersion = '@version ' + newVersion;
147-
148-
149-
// replace version in config files and dev-files
150-
fs.readdirSync(SRC_DIR).forEach(function(file) {
151-
if (isJavascriptFile(file)) {
152-
replaceInFile(SRC_DIR+file, fromVersion, toVersion);
153-
}
154-
});
155-
filesToBuild.devFiles.forEach(function (filePath) {
156-
replaceInFile(filePath, fromVersion, toVersion);
157-
});
158145

159146
replaceInFile('package.json', '"version": "' + currentVersion + '"', '"version": "' + newVersion + '"');
160147
replaceInFile('formvalidator.jquery.json', '"version": "' + currentVersion + '"', '"version": "' + newVersion + '"');

form-validator/brazil.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
*
1212
* @website http://formvalidator.net/#brazil-validators
1313
* @license MIT
14-
* @version 2.2.163
1514
*/
1615

1716
$.formUtils.addValidator({

form-validator/date.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
*
1111
* @website http://formvalidator.net/#location-validators
1212
* @license MIT
13-
* @version 2.2.163
1413
*/
1514
(function($) {
1615

form-validator/file.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
*
1111
* @website http://formvalidator.net/#file-validators
1212
* @license MIT
13-
* @version 2.2.163
1413
*/
1514
(function($, window) {
1615

form-validator/html5.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
*
1818
* @website http://formvalidator.net/
1919
* @license MIT
20-
* @version 2.2.157
2120
*/
2221
(function($, window) {
2322

form-validator/jsconf.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
*
88
* @website http://formvalidator.net/#location-validators
99
* @license MIT
10-
* @version 2.2.163
1110
*/
1211
(function($) {
1312

form-validator/lang/cz.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*
77
* @website http://formvalidator.net/
88
* @license MIT
9-
* @version 2.2.163
109
*/
1110
(function($, window) {
1211

form-validator/lang/de.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*
77
* @website http://formvalidator.net/
88
* @license MIT
9-
* @version 2.2.163
109
*/
1110
(function($, window) {
1211

form-validator/lang/es.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*
77
* @website http://formvalidator.net/
88
* @license MIT
9-
* @version 2.2.163
109
*/
1110
(function($, window) {
1211

form-validator/lang/fr.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*
77
* @website http://formvalidator.net/
88
* @license MIT
9-
* @version 2.2.163
109
*/
1110
(function($, window) {
1211

form-validator/lang/pl.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*
77
* @website http://formvalidator.net/
88
* @license MIT
9-
* @version 2.2.163
109
*/
1110
(function($, window) {
1211

form-validator/lang/pt.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*
77
* @website http://formvalidator.net/
88
* @license MIT
9-
* @version 2.2.163
109
*/
1110
(function($, window) {
1211

form-validator/lang/ro.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*
77
* @website http://formvalidator.net/
88
* @license MIT
9-
* @version 2.2.163
109
*/
1110
(function($, window) {
1211

form-validator/lang/ru.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*
77
* @website http://formvalidator.net/
88
* @license MIT
9-
* @version 2.2.163
109
*/
1110
(function($, window) {
1211

form-validator/lang/sv.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*
77
* @website http://formvalidator.net/
88
* @license MIT
9-
* @version 2.2.163
109
*/
1110
(function($, window) {
1211

form-validator/location.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
*
1111
* @website http://formvalidator.net/#location-validators
1212
* @license MIT
13-
* @version 2.2.163
1413
*/
1514
(function($) {
1615

form-validator/sanitize.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
*
2424
* @website http://formvalidator.net/
2525
* @license MIT
26-
* @version 2.2.163
2726
*/
2827
(function($, window) {
2928

form-validator/security.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
*
1515
* @website http://formvalidator.net/#security-validators
1616
* @license MIT
17-
* @version 2.2.163
1817
*/
1918
(function($, window) {
2019

form-validator/sweden.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
*
1414
* @website http://formvalidator.net/#swedish-validators
1515
* @license MIT
16-
* @version 2.2.163
1716
*/
1817
(function($, window) {
1918

form-validator/toggleDisabled.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
*
99
* @website http://formvalidator.net/
1010
* @license MIT
11-
* @version 2.2.138
1211
*/
1312
(function($, window, undefined) {
1413

form-validator/uk.dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
*
1010
* @website http://formvalidator.net/#uk-validators
1111
* @license MIT
12-
* @version 2.2.163
1312
*/
1413
$.formUtils.addValidator({
1514
name : 'ukvatnumber',

0 commit comments

Comments
 (0)