|
48 | 48 | if ( (documentIssue.bug_status !== serverIssue.bug_status) || |
49 | 49 | (documentIssue.short_desc !== serverIssue.short_desc) ){ |
50 | 50 |
|
| 51 | + // changes from NEW->ASSIGNED aren't noteworthy |
| 52 | + if ( ! (documentIssue.bug_status == "NEW" && |
| 53 | + serverIssue.bug_status == "ASSIGNED") ) |
51 | 54 | serverIssue.issue_state = "updated"; |
52 | 55 | } |
53 | 56 | } |
54 | 57 | else{ |
55 | 58 | // not found in the document. it's a new issue if the bug_status |
56 | 59 | // is not RESOLVED |
57 | 60 | if (serverIssue.bug_status === "RESOLVED") { |
58 | | - serverIssue.issue_state = 'resolved'; |
| 61 | + //why do we want to show resolved issues that |
| 62 | + //have already been removed from the spec? |
| 63 | + |
| 64 | + //serverIssue.issue_state = 'resolved'; |
59 | 65 | } else { |
60 | 66 | serverIssue.issue_state = "new"; |
61 | 67 | } |
|
82 | 88 |
|
83 | 89 | for (var issueId in issueList){ |
84 | 90 |
|
85 | | - // bind the bug data to the bug template |
86 | | - var issueFragment = this.renderIssue(issueList[issueId]); |
87 | | - |
88 | | - var wrapper = document.createElement("div"); |
89 | | - var trigger = document.createElement("a"); |
90 | | - trigger.className = "issue-markup-trigger"; |
91 | | - trigger.href = "#"; |
92 | | - trigger.innerHTML = "toggle markup" |
93 | | - |
94 | 91 | if (issueList[issueId]["issue_state"]){ |
| 92 | + |
| 93 | + // bind the bug data to the bug template |
| 94 | + var issueFragment = this.renderIssue(issueList[issueId]); |
| 95 | + |
| 96 | + var wrapper = document.createElement("div"); |
| 97 | + var trigger = document.createElement("a"); |
| 98 | + trigger.className = "issue-markup-trigger"; |
| 99 | + trigger.href = "#"; |
| 100 | + trigger.innerHTML = "toggle markup" |
| 101 | + |
95 | 102 | wrapper.setAttribute("data-issue_state", issueList[issueId]["issue_state"]); |
| 103 | + |
| 104 | + wrapper.appendChild(trigger); |
| 105 | + wrapper.appendChild(issueFragment); |
| 106 | + fragment.appendChild(wrapper); |
96 | 107 | } |
97 | | - |
98 | | - wrapper.appendChild(trigger); |
99 | | - wrapper.appendChild(issueFragment); |
100 | | - fragment.appendChild(wrapper); |
101 | 108 | } |
102 | 109 |
|
103 | 110 | var issueListContainer = document.querySelector("#issue-list"); |
|
0 commit comments