Skip to content

Commit d2505cb

Browse files
committed
fix bug annotation script and styling
1 parent 873bec3 commit d2505cb

3 files changed

Lines changed: 35 additions & 20 deletions

File tree

css3-regions/BugzillaTrackerCSSRegions.js

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,20 @@
4848
if ( (documentIssue.bug_status !== serverIssue.bug_status) ||
4949
(documentIssue.short_desc !== serverIssue.short_desc) ){
5050

51+
// changes from NEW->ASSIGNED aren't noteworthy
52+
if ( ! (documentIssue.bug_status == "NEW" &&
53+
serverIssue.bug_status == "ASSIGNED") )
5154
serverIssue.issue_state = "updated";
5255
}
5356
}
5457
else{
5558
// not found in the document. it's a new issue if the bug_status
5659
// is not RESOLVED
5760
if (serverIssue.bug_status === "RESOLVED") {
58-
serverIssue.issue_state = 'resolved';
61+
//why do we want to show resolved issues that
62+
//have already been removed from the spec?
63+
64+
//serverIssue.issue_state = 'resolved';
5965
} else {
6066
serverIssue.issue_state = "new";
6167
}
@@ -82,22 +88,23 @@
8288

8389
for (var issueId in issueList){
8490

85-
// bind the bug data to the bug template
86-
var issueFragment = this.renderIssue(issueList[issueId]);
87-
88-
var wrapper = document.createElement("div");
89-
var trigger = document.createElement("a");
90-
trigger.className = "issue-markup-trigger";
91-
trigger.href = "#";
92-
trigger.innerHTML = "toggle markup"
93-
9491
if (issueList[issueId]["issue_state"]){
92+
93+
// bind the bug data to the bug template
94+
var issueFragment = this.renderIssue(issueList[issueId]);
95+
96+
var wrapper = document.createElement("div");
97+
var trigger = document.createElement("a");
98+
trigger.className = "issue-markup-trigger";
99+
trigger.href = "#";
100+
trigger.innerHTML = "toggle markup"
101+
95102
wrapper.setAttribute("data-issue_state", issueList[issueId]["issue_state"]);
103+
104+
wrapper.appendChild(trigger);
105+
wrapper.appendChild(issueFragment);
106+
fragment.appendChild(wrapper);
96107
}
97-
98-
wrapper.appendChild(trigger);
99-
wrapper.appendChild(issueFragment);
100-
fragment.appendChild(wrapper);
101108
}
102109

103110
var issueListContainer = document.querySelector("#issue-list");

css3-regions/Overview.html

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,13 @@
149149
background: #eee;
150150
text-decoration: none;
151151
color: #444;
152-
position: absolute;
152+
/* this was causing all the trigger
153+
links to stack up in one spot,
154+
even though the wrapper is
155+
relative position */
156+
/*position: absolute;
153157
right: 10px;
154-
top: 10px;
158+
top: 10px; */
155159
z-index: 1;
156160
}
157161

@@ -224,13 +228,13 @@
224228

225229
<h1 id=css-regions-module>CSS Regions Module Level 3</h1>
226230

227-
<h2 class="no-num no-toc" id=longstatus-date>Editor's Draft 12 April 2012</h2>
231+
<h2 class="no-num no-toc" id=longstatus-date>Editor's Draft 14 April 2012</h2>
228232

229233
<dl>
230234
<dt>This version:
231235

232236
<dd><a
233-
href="http://www.w3.org/TR/2012/ED-css3-regions-20120412/">http://www.w3.org/csswg/css3-regions</a>
237+
href="http://www.w3.org/TR/2012/ED-css3-regions-20120414/">http://www.w3.org/csswg/css3-regions</a>
234238

235239
<dt>Latest version:
236240

css3-regions/Overview.src.html

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,13 @@
147147
background: #eee;
148148
text-decoration: none;
149149
color: #444;
150-
position: absolute;
150+
/* this was causing all the trigger
151+
links to stack up in one spot,
152+
even though the wrapper is
153+
relative position */
154+
/*position: absolute;
151155
right: 10px;
152-
top: 10px;
156+
top: 10px; */
153157
z-index: 1;
154158
}
155159

0 commit comments

Comments
 (0)