Skip to content

Commit 313cfe4

Browse files
Changed to only set defaultValue on focus to allow user to unset the input value
1 parent f2cfbcd commit 313cfe4

File tree

1 file changed

+22
-16
lines changed

1 file changed

+22
-16
lines changed

jquery-ui-timepicker-addon.js

Lines changed: 22 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,10 @@ $.extend(Timepicker.prototype, {
230230
if(tp_inst._defaults.maxDateTime !== undefined && tp_inst._defaults.maxDateTime instanceof Date) {
231231
tp_inst._defaults.maxDate = new Date(tp_inst._defaults.maxDateTime.getTime());
232232
}
233+
tp_inst.$input.bind('focus', function() {
234+
tp_inst._onFocus();
235+
});
236+
233237
return tp_inst;
234238
},
235239

@@ -748,22 +752,6 @@ $.extend(Timepicker.prototype, {
748752
// on time change is also called when the time is updated in the text field
749753
//########################################################################
750754
_onTimeChange: function() {
751-
if( !this.$input.val() && this._defaults.defaultValue ) {
752-
this.$input.val(this._defaults.defaultValue);
753-
var inst = $.datepicker._getInst(this.$input.get(0)),
754-
tp_inst = $.datepicker._get(inst, 'timepicker');
755-
if (tp_inst) {
756-
if (tp_inst._defaults.timeOnly && (inst.input.val() != inst.lastVal)) {
757-
try {
758-
$.datepicker._updateDatepicker(inst);
759-
}
760-
catch (err) {
761-
$.datepicker.log(err);
762-
}
763-
}
764-
}
765-
}
766-
767755
var hour = (this.hour_slider) ? this.hour_slider.slider('value') : false,
768756
minute = (this.minute_slider) ? this.minute_slider.slider('value') : false,
769757
second = (this.second_slider) ? this.second_slider.slider('value') : false,
@@ -878,6 +866,24 @@ $.extend(Timepicker.prototype, {
878866
}
879867

880868
this.$input.trigger("change");
869+
},
870+
871+
_onFocus: function() {
872+
if( !this.$input.val() && this._defaults.defaultValue ) {
873+
this.$input.val(this._defaults.defaultValue);
874+
var inst = $.datepicker._getInst(this.$input.get(0)),
875+
tp_inst = $.datepicker._get(inst, 'timepicker');
876+
if (tp_inst) {
877+
if (tp_inst._defaults.timeOnly && (inst.input.val() != inst.lastVal)) {
878+
try {
879+
$.datepicker._updateDatepicker(inst);
880+
}
881+
catch (err) {
882+
$.datepicker.log(err);
883+
}
884+
}
885+
}
886+
}
881887
}
882888

883889
});

0 commit comments

Comments
 (0)