Skip to content

Commit ff31dad

Browse files
author
Gabriel Schulhof
committed
[popup] Yank screen resizing code - allow the CSS width: 100% and height: 100% to work its magic
1 parent c71642b commit ff31dad

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

js/widgets/popup.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,6 @@ define( [ "jquery",
4444
this.close();
4545
},
4646

47-
_handleWindowResize: function( e ) {
48-
if ( this._isOpen ) {
49-
this._resizeScreen();
50-
}
51-
},
52-
5347
_handleWindowKeyUp: function( e ) {
5448
if ( this._isOpen && e.keyCode === $.mobile.keyCode.ESCAPE ) {
5549
this._eatEventAndClose( e );
@@ -96,7 +90,6 @@ define( [ "jquery",
9690
{
9791
src: $( window ),
9892
handler: {
99-
resize: $.proxy( this, "_handleWindowResize" ),
10093
keyup: $.proxy( this, "_handleWindowKeyUp" )
10194
}
10295
}
@@ -117,10 +110,6 @@ define( [ "jquery",
117110
});
118111
},
119112

120-
_resizeScreen: function() {
121-
this._ui.screen.height( Math.max( $( window ).height(), $( document ).height() ) );
122-
},
123-
124113
_applyTheme: function( dst, theme ) {
125114
var classes = ( dst.attr( "class" ) || "").split( " " ),
126115
alreadyAdded = true,
@@ -399,7 +388,6 @@ define( [ "jquery",
399388
_openPrereqContainer: function() {
400389
this._applyTransition( "none" );
401390
this._ui.container.removeClass( "in" );
402-
this._resizeScreen();
403391
},
404392

405393
_openPrereqsComplete: function() {
@@ -435,7 +423,6 @@ define( [ "jquery",
435423
this._setTheme( this._page.jqmData( "theme" ) || $.mobile.getInheritedTheme( this._page, "c" ) );
436424
}
437425

438-
this._resizeScreen();
439426
this._ui.screen.removeClass( "ui-screen-hidden" );
440427

441428
this._ui.container

0 commit comments

Comments
 (0)