Skip to content

Commit fa4ee7b

Browse files
committed
Fix #11
1 parent ad7ea4c commit fa4ee7b

File tree

5 files changed

+18
-3
lines changed

5 files changed

+18
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
### 0.2.5 - 2016-12-13
2+
3+
- Fixed #11.
4+
15
### 0.2.4 - 2016-02-29
26

37
- Fixed #8.

index.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,16 +259,17 @@ module.exports = postcss.plugin('postcss-filter-gradient', function (opts) {
259259
var gradient;
260260
var filter;
261261

262-
if (hasFilter(rule)) {
262+
gradient = getGradientFromRule(rule);
263+
264+
// if linear-gradient and `filter` both exist, warn users
265+
if (gradient.value && hasFilter(rule)) {
263266
rule.warn(
264267
result,
265268
'The `filter` declaration already exists, we have skipped this rule.'
266269
);
267270
return;
268271
}
269272

270-
gradient = getGradientFromRule(rule);
271-
272273
if (gradient.warnings) {
273274
gradient.decl.warn(result, gradient.warnings);
274275
}

test/fixtures/filter-not-warning.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
a {
2+
filter: alpha(opacity=50);
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
a {
2+
filter: alpha(opacity=50);
3+
}

test/test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ describe('postcss-filter-gradient', function () {
4848
test('filter', {}, done, warnings);
4949
});
5050

51+
it('should not waring when linear-gradient does\'nt exists', function (done) {
52+
test('filter-not-warning', { }, done);
53+
});
54+
5155
it('should do nothing when handle invalid linear gradient syntax', function (done) {
5256
var warnings = [
5357
'`linear-gradient()` is not a valid linear gradient value.',

0 commit comments

Comments
 (0)