Skip to content

Fetching CSS does not complete #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edtalmadge opened this issue Mar 23, 2016 · 11 comments
Closed

Fetching CSS does not complete #4

edtalmadge opened this issue Mar 23, 2016 · 11 comments
Labels

Comments

@edtalmadge
Copy link

Great plugin.

I tried using it on a folder containing hundreds of CSS files.

A message appears stating:
"HTML CSS Class Completion: Fetching CSS rules from CSS files, please wait."

The message never goes away.
The CSS intellisense does not function.

@zignd
Copy link
Owner

zignd commented Mar 23, 2016

You're right, the message never goes away, but what actually happens is that after some seconds, or maybe minutes, depending on how big is your project, another message pops up stating that the fetching process have finished.

Also, I've just ran some tests with the plugin on the latest VS Code version and it's working.

I'm also planning to change this notification system to make use of the VS Code status bar on this weekend, so it will look nicer.

@edtalmadge
Copy link
Author

Sounds great.

I left VS Code open overnight. The "Fetching CSS rules from CSS files, please wait" message is still there. But, the CSS intellisense does not seem to be running yet.

How does the CSS intellisense normally work? Should I place my cursor between the quotes in class="" and just start typing?
Or, should I place my cursor between the quotes in class="" and press control + space?

@Howshall
Copy link

Howshall commented May 4, 2016

Agree that while v0.0.2 extension is working normally for some of my 'normal' production HTML (So extension initially displays 'Fetching CSS rules from CSS files, please wait.' VSCode notification, then after a short while 2nd 'Finished fetching CSS rules from CSS files.' VSCode - See attached screenshot for good behaviour reference)
html css classes extension 2x notifications

However for one of my more unusual production HTML pages which has 1x External Internet CSS file + mostly inline CSS rules I can re-produce this error of v0.0.2 never displaying 2nd 'Finished...' message and never enabling CSS class completion within that page.

Now in terms of inline CSS styles I know that's currently a [Not implemented yet] feature clearly stated on project homepage, so I guess it must be the external CSS Internet URL that is confusing/breaking the extension completing atm?

Hopefully the attached cut down 'index - Copy.html' (had to change it's extension to .txt to allow upload) I'm attaching will assist @zignd debug this issue and further improve this extension :-)

@prep4gmat
Copy link

+1

@zignd zignd added the bug label May 23, 2016
@daniloar
Copy link

daniloar commented Jun 2, 2016

+1

4 similar comments
@anuragd7
Copy link

+1

@hillbillydev
Copy link

+1

@dafonso
Copy link

dafonso commented Jul 15, 2016

+1

@levka9
Copy link

levka9 commented Jul 29, 2016

+1

@zignd
Copy link
Owner

zignd commented Sep 10, 2016

Would you guys mind testing it again? I suppose the issue is fixed now as I completely rewrote the extension and fixed some bugs on it, the newest release is already on the Marketplace. Thanks!

@Howshall
Copy link

Confirm that for both of previously tested projects new discrete bottom status bar messages + bottom left lightening icon now say that caching CSS rules have completed within expected shortish timescales.

html css classes extension new status bar display

Note extension still doesn't read/cache Internet hosted, or inline specified CSS rules, so you should only expect CSS class completion for CSS styles that are in locally linked external .css files atm.

Congrats @zignd on much more subtle notifications and now no longer needing to click to dismiss messages that would otherwise block screenspace 👍

@zignd zignd closed this as completed Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants