-
Notifications
You must be signed in to change notification settings - Fork 85
Fetching CSS does not complete #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You're right, the message never goes away, but what actually happens is that after some seconds, or maybe minutes, depending on how big is your project, another message pops up stating that the fetching process have finished. Also, I've just ran some tests with the plugin on the latest VS Code version and it's working. I'm also planning to change this notification system to make use of the VS Code status bar on this weekend, so it will look nicer. |
Sounds great. I left VS Code open overnight. The "Fetching CSS rules from CSS files, please wait" message is still there. But, the CSS intellisense does not seem to be running yet. How does the CSS intellisense normally work? Should I place my cursor between the quotes in class="" and just start typing? |
Agree that while v0.0.2 extension is working normally for some of my 'normal' production HTML (So extension initially displays 'Fetching CSS rules from CSS files, please wait.' VSCode notification, then after a short while 2nd 'Finished fetching CSS rules from CSS files.' VSCode - See attached screenshot for good behaviour reference) However for one of my more unusual production HTML pages which has 1x External Internet CSS file + mostly inline CSS rules I can re-produce this error of v0.0.2 never displaying 2nd 'Finished...' message and never enabling CSS class completion within that page. Now in terms of inline CSS styles I know that's currently a [Not implemented yet] feature clearly stated on project homepage, so I guess it must be the external CSS Internet URL that is confusing/breaking the extension completing atm? Hopefully the attached cut down 'index - Copy.html' (had to change it's extension to .txt to allow upload) I'm attaching will assist @zignd debug this issue and further improve this extension :-) |
+1 |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
Would you guys mind testing it again? I suppose the issue is fixed now as I completely rewrote the extension and fixed some bugs on it, the newest release is already on the Marketplace. Thanks! |
Confirm that for both of previously tested projects new discrete bottom status bar messages + bottom left lightening icon now say that caching CSS rules have completed within expected shortish timescales. Note extension still doesn't read/cache Internet hosted, or inline specified CSS rules, so you should only expect CSS class completion for CSS styles that are in locally linked external .css files atm. Congrats @zignd on much more subtle notifications and now no longer needing to click to dismiss messages that would otherwise block screenspace 👍 |
Great plugin.
I tried using it on a folder containing hundreds of CSS files.
A message appears stating:
"HTML CSS Class Completion: Fetching CSS rules from CSS files, please wait."
The message never goes away.
The CSS intellisense does not function.
The text was updated successfully, but these errors were encountered: