Re: [css-writing-modes-3] text-combine-upright-inherit-all-001 and its reference file

On 07/05/2015 10:16 PM, Koji Ishii wrote:
> Comments inline:
>

>>>     Koji, the test is completely invalid. As Gérard wrote, the reference is
>>     *just a copy of the test*. Such a reftest will never, ever fail on any
>>     real implementation ever.
>>
>>     The reference file must be the same effect by some *alternative* method.
>>     Otherwise you are just testing that two identical source files render
>>     identically--which is useless.
>>
>>     If you are trying to test if
>>        <div class=vrl><span class=tcy>66</span></div>
>>     renders the same as
>>        <div class=vrl><span class=tcy><span>66</span></span></div>
>>     then your test file should use
>>        <div class=vrl><span class=tcy><span>66</span></span></div>
>>     while your reference file uses
>>        <div class=vrl><span class=tcy>66</span></div>
>>     Then you are actually testing if the two *different* sources render
>>     equivalently, and the test has some meaning.
>>
>
> I'm not sure if I follow, that's exactly what the test is as of now[1],
> and the suggestion is to change the reference to:
>    <div>66</div>
>
> So are you saying the test should fix as suggested, or should not?

Sorry, I missed that then. :( It's correct. I thought there was no difference.

I would increase the test's coverage, however, by having additional containers:

     <div class=vrl><span class=tcy>66</span></div> /* reference */
     <div class="tcy">
       <div class="vrl"><span><span>66</span></span></div>
       <div class="vlr"><span><span>66</span></span></div>
     </div>

This tests not just inheritance through inline elements, but also from
block to inline, and from block to block. It's also good to check both
writing modes; here it's easy, just add
   .vlr { writing-mode: vertical-lr; }

~fantasai

Received on Monday, 20 July 2015 17:04:52 UTC