Thread: [cssparser-developers] Where should a Locator point to?

Hi,

I plan to rewrtie the adding of Locators to CSSOM objects and 
LexicalValues. At the moment the following objects get a Locator:

* CSSCharsetRuleImpl
* CSSImportRuleImpl
* CSSFontFaceRuleImpl
* CSSMediaRuleImpl
* CSSPageRuleImpl
* CSSStyleRuleImpl
* CSSUnknownRuleImpl
* Property
* LexicalUnitImpl

Which location in the source code should the Locator point to?

Should it always point to the first character?

Example:

@import "../../dojo/resources/dojo.css";
^                           Locator for CSSImportRuleImpl

#testLayout {
^                           Locator for CSSStyleRuleImpl
     height: 100%;
     ^                       Locator for Property 'height'
             ^               Locator for LexicalUnitImpl '100%'
     border: 1px solid black;
     ^                       Locator for Property 'border'
             ^               Locator for LexicalUnitImpl '1px'
                 ^           Locator for LexicalUnitImpl 'solid'
                       ^     Locator for LexicalUnitImpl 'black'
}

-- 
Waldbaer

Waldbaer wrote:
> Which location in the source code should the Locator point to?
>
> Should it always point to the first character?
>
> Example:
>
> @import "../../dojo/resources/dojo.css";
> ^                           Locator for CSSImportRuleImpl
>
> #testLayout {
> ^                           Locator for CSSStyleRuleImpl
>   
That seems like a sensible approach to me.

What's the current behavior?


On Fri, Nov 21, 2008 at 5:26 AM, Waldbaer <wal...@us...>wrote:

> Hi,
>
> I plan to rewrtie the adding of Locators to CSSOM objects and
> LexicalValues. At the moment the following objects get a Locator:
>
> * CSSCharsetRuleImpl
> * CSSImportRuleImpl
> * CSSFontFaceRuleImpl
> * CSSMediaRuleImpl
> * CSSPageRuleImpl
> * CSSStyleRuleImpl
> * CSSUnknownRuleImpl
> * Property
> * LexicalUnitImpl
>
> Which location in the source code should the Locator point to?
>
> Should it always point to the first character?
>
> Example:
>
> @import "../../dojo/resources/dojo.css";
> ^                           Locator for CSSImportRuleImpl
>
> #testLayout {
> ^                           Locator for CSSStyleRuleImpl
>     height: 100%;
>     ^                       Locator for Property 'height'
>             ^               Locator for LexicalUnitImpl '100%'
>     border: 1px solid black;
>     ^                       Locator for Property 'border'
>             ^               Locator for LexicalUnitImpl '1px'
>                 ^           Locator for LexicalUnitImpl 'solid'
>                       ^     Locator for LexicalUnitImpl 'black'
> }
>
> --
> Waldbaer
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> cssparser-developers mailing list
> css...@li...
> https://lists.sourceforge.net/lists/listinfo/cssparser-developers
>



-- 
Daniel Gredler
http://daniel.gredler.net/

Daniel Gredler schrieb:
> What's the current behavior?

It's somehow mixed ...

-- 
Waldbaer

Then standardizing on the first character sounds good to me!


On Mon, Nov 24, 2008 at 3:43 AM, Waldbaer <wal...@us...>wrote:

> Daniel Gredler schrieb:
> > What's the current behavior?
>
> It's somehow mixed ...
>
> --
> Waldbaer
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> cssparser-developers mailing list
> css...@li...
> https://lists.sourceforge.net/lists/listinfo/cssparser-developers
>



-- 
Daniel Gredler
http://daniel.gredler.net/

Daniel Gredler schrieb:
> Then standardizing on the first character sounds good to me!

I checked in some changes, so that the CSSOMObject's Locators point to 
the first character. This does not effect line/char numbers in exceptions.

-- 
Waldbaer