check import cycles #535
Merged
check import cycles #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76ebef6 to
c5a8870
Compare
…hetic-numbat-90ac1e6ee1
romainmenke
commented
Jul 24, 2023
RyanZim
approved these changes
Sep 30, 2023
Collaborator
RyanZim
left a comment
There was a problem hiding this comment.
Sorry so slow in reviewing here; looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves : #462
It is untrue that browsers only use the last import.
They use all of them.
Up until now however this wasn't observable.
With the introduction of
@layerCSS now has something that is registered when first encountered and can not be overwritten later, making the real behavior clear.When
skipDuplicates: falseis setpostcss-importwill produce CSS that is equivalent to browser behavior.This change adds handling of cyclical imports in the same way as browsers resolve these cycles. This removes any differences between bundled or unbundled CSS as affected by import order.
See WebKit implementation : https://github.com/WebKit/WebKit/blob/main/Source/WebCore/css/StyleRuleImport.cpp#L123-L131