jquery / jquery

Downloads

jQuery JavaScript Library — Read more

This URL has Read+Write access

Make sure we use detach instead of remove in replaceWith. Fixes #5785.

jeresig (author)

Mon Jan 11 12:57:45 -0800 2010

commit 36a98b95c2f3f7617ddf
tree bbbaeb579109584adf91
parent 366039a6f05ffa09630e

Showing 2 changed files with 11 additions and 2 deletions.

M	src/manipulation.js	2 ••
M	test/unit/manipulation.js	11 ••••

src/manipulation.js

View file @ 36a98b9

@@ -216,7 +216,7 @@ jQuery.fn.extend({
       return this.each(function() {
         var next = this.nextSibling, parent = this.parentNode;
 
-        jQuery(this).remove();
+        jQuery(this).detach();
 
         if ( next ) {
           jQuery(next).before( value );

test/unit/manipulation.js

View file @ 36a98b9

@@ -626,7 +626,7 @@ test("insertAfter(String|Element|Array&lt;Element&gt;|jQuery)", function() {
 });
 
 var testReplaceWith = function(val) {
-  expect(14);
+  expect(16);
   jQuery('#yahoo').replaceWith(val( '<b id="replace">buga</b>' ));
   ok( jQuery("#replace")[0], 'Replace element with string' );
   ok( !jQuery("#yahoo")[0], 'Verify that original element is gone, after string' );
@@ -648,6 +648,15 @@ var testReplaceWith = function(val) {
   ok( jQuery("#mark")[0], 'Replace element with set of elements' );
   ok( !jQuery("#yahoo")[0], 'Verify that original element is gone, after set of elements' );
 
+  reset();
+  var tmp = jQuery("<div/>").appendTo("body").click(function(){ ok(true, "Newly bound click run." ); });
+  var y = jQuery('#yahoo').click(function(){ ok(true, "Previously bound click run." ); });
+  y.replaceWith( tmp );
+  tmp.click();
+  y.click();
+
+  reset();
+
   var set = jQuery("<div/>").replaceWith(val("<span>test</span>"));
   equals( set[0].nodeName.toLowerCase(), "span", "Replace the disconnected node." );
   equals( set.length, 1, "Replace the disconnected node." );

0 notes on commit `36a98b9` Show line notes below

Please log in to comment.

...	...	@@ -216,7 +216,7 @@ jQuery.fn.extend({
216	216	return this.each(function() {
217	217	var next = this.nextSibling, parent = this.parentNode;
218	218
219		- jQuery(this).remove();
	219	+ jQuery(this).detach();
220	220
221	221	if ( next ) {
222	222	jQuery(next).before( value );

...	...	@@ -626,7 +626,7 @@ test("insertAfter(String\|Element\|Array<Element>\|jQuery)", function() {
626	626	});
627	627
628	628	var testReplaceWith = function(val) {
629		- expect(14);
	629	+ expect(16);
630	630	jQuery('#yahoo').replaceWith(val( '<b id="replace">buga</b>' ));
631	631	ok( jQuery("#replace")[0], 'Replace element with string' );
632	632	ok( !jQuery("#yahoo")[0], 'Verify that original element is gone, after string' );
...	...	@@ -648,6 +648,15 @@ var testReplaceWith = function(val) {
648	648	ok( jQuery("#mark")[0], 'Replace element with set of elements' );
649	649	ok( !jQuery("#yahoo")[0], 'Verify that original element is gone, after set of elements' );
650	650
	651	+ reset();
	652	+ var tmp = jQuery("<div/>").appendTo("body").click(function(){ ok(true, "Newly bound click run." ); });
	653	+ var y = jQuery('#yahoo').click(function(){ ok(true, "Previously bound click run." ); });
	654	+ y.replaceWith( tmp );
	655	+ tmp.click();
	656	+ y.click();
	657	+
	658	+ reset();
	659	+
651	660	var set = jQuery("<div/>").replaceWith(val("<span>test</span>"));
652	661	equals( set[0].nodeName.toLowerCase(), "span", "Replace the disconnected node." );
653	662	equals( set.length, 1, "Replace the disconnected node." );

jquery / jquery

0 notes on commit `36a98b9` Show line notes below

Your current locale selection: English. Choose another?

Keyboard Shortcuts

Site wide shortcuts

Commit list

Pull request list

Issues

Network Graph

jquery / jquery

0 notes on commit 36a98b9 Show line notes below

Your current locale selection: English. Choose another?

Keyboard Shortcuts

Site wide shortcuts

Commit list

Pull request list

Issues

Network Graph

0 notes on commit `36a98b9` Show line notes below