Slider: Create a copy of the options.values array for the return value of _value(). Fixes #4751 - Dragging slider modifies values, even if callback returns false.

scottgonzalez · scottgonzalez · commit 1a28670720cb · 2009-08-04T23:35:08.000Z
Thanks bkrausz.
diff --git a/ui/ui.slider.js b/ui/ui.slider.js
@@ -482,7 +482,9 @@ $.widget("ui.slider", $.extend({}, $.ui.mouse, {
 
 			return val;
 		} else {
-			return this.options.values;
+			// .slice() creates a copy of the array
+			// this prevents outside manipulation of the internal state
+			return this.options.values.slice();
 		}
 
 	},

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,9 @@ $.widget("ui.slider", $.extend({}, $.ui.mouse, {`
`482`	`482`
`483`	`483`	`return val;`
`484`	`484`	`} else {`
`485`		`- return this.options.values;`
	`485`	`+ // .slice() creates a copy of the array`
	`486`	`+ // this prevents outside manipulation of the internal state`
	`487`	`+ return this.options.values.slice();`
`486`	`488`	`}`
`487`	`489`
`488`	`490`	`},`