Dialog, position: Removed bgiframe option; always use bgiframe when a…

…vailable. Fixes #5071 - Remove bgiframe option from all plugins.
jquery · Jan 19, 2010 · 010385b2fa4f0656953c2fc70c363c9cd9f74a9d · 010385b
1 parent ebf5160
commit 010385b2fa4f0656953c2fc70c363c9cd9f74a9d
diff --git a/demos/dialog/animated.html b/demos/dialog/animated.html
@@ -17,7 +17,6 @@
 	<script type="text/javascript" src="../../ui/jquery.effects.explode.js"></script>
 	<link type="text/css" href="../demos.css" rel="stylesheet" />
 	<script type="text/javascript">
-	$.ui.dialog.prototype.options.bgiframe = true;
 	// increase the default animation speed to exaggerate the effect
 	$.fx.speeds._default = 1000;
 	$(function() {

diff --git a/demos/dialog/default.html b/demos/dialog/default.html
@@ -14,7 +14,6 @@
 	<script type="text/javascript" src="../../ui/jquery.ui.dialog.js"></script>
 	<link type="text/css" href="../demos.css" rel="stylesheet" />
 	<script type="text/javascript">
-	$.ui.dialog.prototype.options.bgiframe = true;
 	$(function() {
 		$("#dialog").dialog();
 	});

diff --git a/demos/dialog/modal-confirmation.html b/demos/dialog/modal-confirmation.html
@@ -19,7 +19,6 @@
 		$("#dialog").dialog("destroy");
 
 		$("#dialog-confirm").dialog({
-			bgiframe: true,
 			resizable: false,
 			height:140,
 			modal: true,

diff --git a/demos/dialog/modal-form.html b/demos/dialog/modal-form.html
@@ -73,7 +73,6 @@
 		}
 
 		$("#dialog-form").dialog({
-			bgiframe: true,
 			autoOpen: false,
 			height: 300,
 			width: 350,

diff --git a/demos/dialog/modal-message.html b/demos/dialog/modal-message.html
@@ -20,7 +20,6 @@
 		$("#dialog").dialog("destroy");
 
 		$("#dialog-message").dialog({
-			bgiframe: true,
 			modal: true,
 			buttons: {
 				Ok: function() {

diff --git a/demos/dialog/modal.html b/demos/dialog/modal.html
@@ -19,7 +19,6 @@
 		$("#dialog").dialog("destroy");
 
 		$("#dialog-modal").dialog({
-			bgiframe: true,
 			height: 140,
 			modal: true
 		});

diff --git a/tests/unit/dialog/dialog_defaults.js b/tests/unit/dialog/dialog_defaults.js
@@ -4,7 +4,6 @@
 
 var dialog_defaults = {
 	autoOpen: true,
-	bgiframe: false,
 	buttons: {},
 	closeOnEscape: true,
 	closeText: 'close',

diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
@@ -27,7 +27,6 @@ var uiDialogClasses =
 $.widget("ui.dialog", {
 	options: {
 		autoOpen: true,
-		bgiframe: false,
 		buttons: {},
 		closeOnEscape: true,
 		closeText: 'close',
@@ -146,7 +145,7 @@ $.widget("ui.dialog", {
 		self._createButtons(options.buttons);
 		self._isOpen = false;
 
-		(options.bgiframe && $.fn.bgiframe && uiDialog.bgiframe());
+		($.fn.bgiframe && uiDialog.bgiframe());
 	},
 	_init: function() {
 		if ( this.options.autoOpen ) {
@@ -606,7 +605,7 @@ $.extend($.ui.dialog.overlay, {
 				height: this.height()
 			});
 
-		(dialog.options.bgiframe && $.fn.bgiframe && $el.bgiframe());
+		($.fn.bgiframe && $el.bgiframe());
 
 		this.instances.push($el);
 		return $el;

diff --git a/ui/jquery.ui.position.js b/ui/jquery.ui.position.js
@@ -140,7 +140,7 @@ $.fn.position = function(options) {
 				}));
 		});
 
-		(options.bgiframe !== false && $.fn.bgiframe && elem.bgiframe());
+		($.fn.bgiframe && elem.bgiframe());
 		elem.offset($.extend(position, { using: options.using }));
 	});
 };