jquery / jquery-ui

Source
Commits
Network (90)
Graphs
Tree: 34912bc

The official jQuery user interface library. — Read more

This URL has Read+Write access

Slider: fixed step alignment to handle negative fractional values. Fixed #5583 - 
Slider displays negative fractional values incorrectly. Thanks for the patch 
watanabe.

rdworth (author)

Tue May 11 05:17:18 -0700 2010

commit 34912bc933d2787b0e31
tree 40182d7cf5e36fcec2a3
parent b7c0823da65254f420e4

ui/jquery.ui.slider.js

6 ••••

ui/jquery.ui.slider.js

View file @ 34912bc

@@ -591,12 +591,12 @@ $.widget( "ui.slider", $.ui.mouse, {
     if ( val > this._valueMax() ) {
       return this._valueMax();
     }
-    var step = this.options.step,
+    var step = ( this.options.step > 0 ) ? this.options.step : 1,
       valModStep = val % step,
       alignValue = val - valModStep;
 
-    if ( valModStep >= ( step / 2 ) ) {
-      alignValue += step;
+    if ( Math.abs(valModStep) * 2 >= step ) {
+      alignValue += ( valModStep > 0 ) ? step : ( -step );
     }
 
     // Since JavaScript has problems with large floats, round

0 notes on commit `34912bc` Show line notes below

Please log in to comment.

...	...	@@ -591,12 +591,12 @@ $.widget( "ui.slider", $.ui.mouse, {
591	591	if ( val > this._valueMax() ) {
592	592	return this._valueMax();
593	593	}
594		- var step = this.options.step,
	594	+ var step = ( this.options.step > 0 ) ? this.options.step : 1,
595	595	valModStep = val % step,
596	596	alignValue = val - valModStep;
597	597
598		- if ( valModStep >= ( step / 2 ) ) {
599		- alignValue += step;
	598	+ if ( Math.abs(valModStep) * 2 >= step ) {
	599	+ alignValue += ( valModStep > 0 ) ? step : ( -step );
600	600	}
601	601
602	602	// Since JavaScript has problems with large floats, round

jquery / jquery-ui

0 notes on commit 34912bc Show line notes below

0 notes on commit `34912bc` Show line notes below