jquery / jquery-ui

Source
Commits
Network (165)
Graphs
Tree: 96e78a2

The official jQuery user interface library. — Read more

This URL has Read+Write access

Dialog: Updated test for default position option. QUnit still fails the test 
though.

scottgonzalez (author)

Wed Jul 14 13:38:16 -0700 2010

commit 96e78a2cb7968fead62c
tree 244ff1c7e0f338cd6233
parent 6de9a5368c3e0523f91f

tests/unit/dialog/dialog_defaults.js

14 ••••

tests/unit/dialog/dialog_defaults.js

View file @ 96e78a2

@@ -17,7 +17,19 @@ var dialog_defaults = {
   minHeight: 150,
   minWidth: 150,
   modal: false,
-  position: 'center',
+  position: {
+    my: 'center',
+    at: 'center',
+    of: window,
+    collision: 'fit',
+    // ensure that the titlebar is never outside the document
+    using: function(pos) {
+      var topOffset = $(this).css(pos).offset().top;
+      if (topOffset < 0) {
+        $(this).css('top', pos.top - topOffset);
+      }
+    }
+  },
   resizable: true,
   show: null,
   stack: true,

2 notes on commit `96e78a2` Show line notes below

bostanio added a note to 96e78a2

Fri Jul 16 18:49:58 -0700 2010

I have a fix for this test framework that will fix this failing test. I'll put it up and send the pull request soon.

jzaefferer added a note to 96e78a2 repo collab

Sat Jul 17 05:04:39 -0700 2010

@bostanio: Send requests about QUnit to http://github.com/jquery/qunit

Please log in to comment.

...	...	@@ -17,7 +17,19 @@ var dialog_defaults = {
17	17	minHeight: 150,
18	18	minWidth: 150,
19	19	modal: false,
20		- position: 'center',
	20	+ position: {
	21	+ my: 'center',
	22	+ at: 'center',
	23	+ of: window,
	24	+ collision: 'fit',
	25	+ // ensure that the titlebar is never outside the document
	26	+ using: function(pos) {
	27	+ var topOffset = $(this).css(pos).offset().top;
	28	+ if (topOffset < 0) {
	29	+ $(this).css('top', pos.top - topOffset);
	30	+ }
	31	+ }
	32	+ },
21	33	resizable: true,
22	34	show: null,
23	35	stack: true,

jquery / jquery-ui

2 notes on commit 96e78a2 Show line notes below

2 notes on commit `96e78a2` Show line notes below