jquery / jquery-ui

Source
Commits
Network (88)
Graphs
Tree: a4488af

The official jQuery user interface library. — Read more

This URL has Read+Write access

Fix 'this.options is undefined' in sortable by using this instead of self

ornicar (author)

Wed May 05 01:43:03 -0700 2010

scottgonzalez (committer)

Wed May 05 04:14:55 -0700 2010

commit a4488aff7c62f3e2db6f
tree 65b1624fe1acde246774
parent 0ad5ac73822fdabef26e

ui/jquery.ui.sortable.js

2 ••

ui/jquery.ui.sortable.js

View file @ a4488af

@@ -81,7 +81,7 @@ $.widget("ui.sortable", $.ui.mouse, {
         [ value ? "addClass" : "removeClass"]( "ui-sortable-disabled" );
     } else {
       // Don't call widget base _setOption for disable as it adds ui-state-disabled class
-      $.Widget.prototype._setOption.apply(self, arguments);
+      $.Widget.prototype._setOption.apply(this, arguments);
     }
   },
 

2 notes on commit `a4488af` Show line notes below

andyshora added a note to a4488af

Wed May 12 03:21:49 -0700 2010

Excellent work guys, this bug had me for a while!

lachlanhardy added a note to a4488af

Mon May 17 21:56:55 -0700 2010

Any chance we can get 1.8.2 released to include this soon?

Please log in to comment.

...	...	@@ -81,7 +81,7 @@ $.widget("ui.sortable", $.ui.mouse, {
81	81	[ value ? "addClass" : "removeClass"]( "ui-sortable-disabled" );
82	82	} else {
83	83	// Don't call widget base _setOption for disable as it adds ui-state-disabled class
84		- $.Widget.prototype._setOption.apply(self, arguments);
	84	+ $.Widget.prototype._setOption.apply(this, arguments);
85	85	}
86	86	},
87	87

jquery / jquery-ui

2 notes on commit a4488af Show line notes below

2 notes on commit `a4488af` Show line notes below