jquery / jquery-ui

Source
Commits
Network (211)
Graphs
Tree: 5311fe2

The official jQuery user interface library. — Read more

This URL has Read+Write access

Menu: Only look for .ui-menu-item elements to determine if a menu item is the first or last element in the menu. Fixes #5528 - Autocomplete: Issue when try to navigate using up key by keyboard in IE6.

scottgonzalez (author)

Mon Jul 19 08:51:05 -0700 2010

commit 5311fe22f327d275f6f8
tree c37f1cf601aeea8ab1c9
parent a090faa833cf5b40105b

ui/jquery.ui.autocomplete.js

4 ••••

ui/jquery.ui.autocomplete.js

View file @ 5311fe2

          
@@ -433,11 +433,11 @@ $.widget("ui.menu", {

   },

   first: function() {

-    return this.active && !this.active.prev().length;

+    return this.active && !this.active.prevAll(".ui-menu-item").length;

   },

   last: function() {

-    return this.active && !this.active.next().length;

+    return this.active && !this.active.nextAll(".ui-menu-item").length;

   },

   move: function(direction, edge, event) {

2 notes on commit `5311fe2` Show line notes below

jzaefferer added a note to 5311fe2 repo collab

Tue Jul 20 00:38:31 -0700 2010

Are the other changes from the menu branch that need to be applied to autocomplete?

scottgonzalez added a note to 5311fe2 repo collab

Tue Jul 20 04:56:53 -0700 2010

I haven't looked over the menu branch yet. I've got a note about merging this change into the menu branch, but I'm not sure when we want to pull menu into master.

Please log in to comment.

...	...	@@ -433,11 +433,11 @@ $.widget("ui.menu", {
433	433	},
434	434
435	435	first: function() {
436		- return this.active && !this.active.prev().length;
	436	+ return this.active && !this.active.prevAll(".ui-menu-item").length;
437	437	},
438	438
439	439	last: function() {
440		- return this.active && !this.active.next().length;
	440	+ return this.active && !this.active.nextAll(".ui-menu-item").length;
441	441	},
442	442
443	443	move: function(direction, edge, event) {

jquery / jquery-ui

2 notes on commit 5311fe2 Show line notes below

Your current locale selection: English. Choose another?

2 notes on commit `5311fe2` Show line notes below