jquery / jquery-ui

Source
Commits
Network (212)
Graphs
Tree: c5770c0

The official jQuery user interface library. — Read more

This URL has Read+Write access

Dialog: modified so that minWidth is respected. Fixes #5531 - dialog width should be at least minWidth on creation.

Ziling Zhao (author)

Mon Apr 19 15:42:34 -0700 2010

scottgonzalez (committer)

Fri Jul 30 12:14:48 -0700 2010

commit c5770c0e84b786ebe55a
tree e9e379ad55242652119f
parent 90caa93a9b4b9b894b05

M	tests/unit/dialog/dialog_tickets.js	21 •••••
M	ui/jquery.ui.dialog.js	4 ••••

tests/unit/dialog/dialog_tickets.js

View file @ c5770c0

...	...	@@ -40,4 +40,25 @@ test("#5184: isOpen in dialogclose event is true", function() {
40	40	el.remove();
41	41	});
42	42
	43	+test("#5531: dialog width should be at least minWidth on creation", function () {
	44	+ el = $('<div></div>').dialog({
	45	+ width: 200,
	46	+ minWidth: 300
	47	+ });
	48	+
	49	+ equals(el.dialog('option', 'width'), 300, "width is minWidth");
	50	+ el.dialog('option', 'width', 200);
	51	+ equals(el.dialog('option', 'width'), 300, "width unchanged when set to < minWidth");
	52	+ el.dialog('option', 'width', 320);
	53	+ equals(el.dialog('option', 'width'), 320, "width changed if set to > minWidth");
	54	+ el.remove();
	55	+
	56	+ el = $('<div></div>').dialog({
	57	+ minWidth: 300
	58	+ });
	59	+ ok(el.dialog('option', 'width') >= 300, "width is at least 300");
	60	+ el.remove();
	61	+
	62	+});
	63	+
43	64	})(jQuery);

ui/jquery.ui.dialog.js

View file @ c5770c0

@@ -628,6 +628,10 @@ $.widget("ui.dialog", {
       height: 0
     });
 
+    if (options.minWidth > options.width) {
+      options.width = options.minWidth;
+    }
+
     // reset wrapper sizing
     // determine the height of all the non-content elements
     nonContentHeight = this.uiDialog.css({

0 notes on commit `c5770c0` Show line notes below

Please log in to comment.

...	...	@@ -628,6 +628,10 @@ $.widget("ui.dialog", {
628	628	height: 0
629	629	});
630	630
	631	+ if (options.minWidth > options.width) {
	632	+ options.width = options.minWidth;
	633	+ }
	634	+
631	635	// reset wrapper sizing
632	636	// determine the height of all the non-content elements
633	637	nonContentHeight = this.uiDialog.css({

jquery / jquery-ui

0 notes on commit c5770c0 Show line notes below

Your current locale selection: English. Choose another?

0 notes on commit `c5770c0` Show line notes below