github github
  • Home
  • Pricing and Signup
  • Training
  • Gist
  • Blog
  • Login

jquery / jquery-ui

  • Admin
  • Watch Unwatch
  • Fork
  • Your Fork
  • Pull Request
  • Download Source
    • 921
    • 212
  • Source
  • Commits
  • Network (212)
  • Graphs
  • Tree: 61e0aea

click here to add a description

click here to add a homepage

  • Switch Branches (8)
    • bind
    • devpreview
    • formcontrols
    • master
    • menu
    • panel
    • tooltip
    • widget-super
  • Switch Tags (21)
    • 1.9m2
    • 1.9m1
    • 1.8rc3
    • 1.8rc2
    • 1.8rc1
    • 1.8b1
    • 1.8a2
    • 1.8a1
    • 1.8.4
    • 1.8.3
    • 1.8.2
    • 1.8.1
    • 1.8
    • 1.7
    • 1.6rc6
    • 1.6rc5
    • 1.6rc3
    • 1.6rc2
    • 1.6
    • 1.5.2
    • 1.5.1
  • Comments
  • Contributors
Sending Request…

The official jQuery user interface library. — Read more

  Cancel

http://jqueryui.com/

  Cancel
  • HTTP
  • Git Read-Only

This URL has Read+Write access

Dialog: Wrap buttons in a div so we can float the div instead of the individual buttons. Fixes #4529 - dialog buttons are accessed in wrong order using tab.
scottgonzalez (author)
Thu Jul 29 17:56:28 -0700 2010
commit  61e0aeac7e626df711e7
tree    7c9740d8542f472f8be5
parent  f00c03139bf83e573b60
M tests/unit/dialog/dialog_options.js 2 ••
M themes/base/jquery.ui.dialog.css 3 •••
M ui/jquery.ui.dialog.js 7 ••••
Txt tests/unit/dialog/dialog_options.js
  • View file @ 61e0aea
... ...
@@ -43,7 +43,7 @@ test("buttons", function() {
43 43
     i++;
44 44
   });
45 45
 
46  
-  ok(btn.parent().hasClass('ui-dialog-buttonpane'), "buttons in container");
  46
+  ok(btn.parent().hasClass('ui-dialog-buttonset'), "buttons in container");
47 47
   btn.trigger("click");
48 48
 
49 49
   var newButtons = {
Txt themes/base/jquery.ui.dialog.css
  • View file @ 61e0aea
... ...
@@ -15,6 +15,7 @@
15 15
 .ui-dialog .ui-dialog-titlebar-close:hover, .ui-dialog .ui-dialog-titlebar-close:focus { padding: 0; }
16 16
 .ui-dialog .ui-dialog-content { position: relative; border: 0; padding: .5em 1em; background: none; overflow: auto; zoom: 1; }
17 17
 .ui-dialog .ui-dialog-buttonpane { text-align: left; border-width: 1px 0 0 0; background-image: none; margin: .5em 0 0 0; padding: .3em 1em .5em .4em; }
18  
-.ui-dialog .ui-dialog-buttonpane button { float: right; margin: .5em .4em .5em 0; cursor: pointer; }
  18
+.ui-dialog .ui-dialog-buttonpane .ui-dialog-buttonset { float: right; }
  19
+.ui-dialog .ui-dialog-buttonpane button { margin: .5em .4em .5em 0; cursor: pointer; }
19 20
 .ui-dialog .ui-resizable-se { width: 14px; height: 14px; right: 3px; bottom: 3px; }
20 21
 .ui-draggable .ui-dialog-titlebar { cursor: move; }
Txt ui/jquery.ui.dialog.js
  • View file @ 61e0aea
... ...
@@ -342,7 +342,10 @@ $.widget("ui.dialog", {
342 342
           'ui-dialog-buttonpane ' +
343 343
           'ui-widget-content ' +
344 344
           'ui-helper-clearfix'
345  
-        );
  345
+        ),
  346
+      uiButtonSet = $( "<div></div>" )
  347
+        .addClass( "ui-dialog-buttonset" )
  348
+        .appendTo( uiDialogButtonPane );
346 349
 
347 350
     // if we already have a button pane, remove it
348 351
     self.uiDialog.find('.ui-dialog-buttonpane').remove();
... ...
@@ -357,7 +360,7 @@ $.widget("ui.dialog", {
357 360
         var button = $('<button type="button"></button>')
358 361
           .text(name)
359 362
           .click(function() { fn.apply(self.element[0], arguments); })
360  
-          .appendTo(uiDialogButtonPane);
  363
+          .appendTo(uiButtonSet);
361 364
         if ($.fn.button) {
362 365
           button.button();
363 366
         }

0 notes on commit 61e0aea

Please log in to comment.
Dedicated Server Powered by the Dedicated Servers and
Cloud Computing of Rackspace Hosting®
  • Blog
  • Support
  • Training
  • Job Board
  • Shop
  • Contact
  • API
  • Status
  • © 2010 GitHub Inc. All rights reserved.
  • Terms of Service
  • Privacy
  • Security
  • English
  • Deutsch
  • Français
  • 日本語
  • Português (BR)
  • 中文
  • See all available languages

Your current locale selection: English. Choose another?

  • English
  • Afrikaans
  • Català
  • Čeština
  • Deutsch
  • Español
  • Français
  • Hrvatski
  • Indonesia
  • Italiano
  • 日本語
  • Nederlands
  • Norsk
  • Polski
  • Português (BR)
  • Српски
  • Svenska
  • 中文