jquery / jquery-ui

Source
Commits
Network (200)
Graphs
Tree: f775b00

The official jQuery user interface library. — Read more

This URL has Read+Write access

Widget: Fixed a problem with the .remove() proxy.

Fixes #5143 - .remove() proxy doesn't work properly.

scottgonzalez (author)

Fri Feb 05 18:12:41 -0800 2010

commit f775b00cfa0ad662dd0e
tree 981a2ba7ae3a2295f1c6
parent f2a9deb611332776e126

ui/jquery.ui.widget.js

16 ••••

ui/jquery.ui.widget.js

View file @ f775b00

@@ -12,12 +12,16 @@
 var _remove = $.fn.remove;
 
 $.fn.remove = function( selector, keepData ) {
-  if ( !keepData ) {
-    $( "*", this ).add( this ).each(function() {
-      $( this ).triggerHandler( "remove" );
-    });
-  }
-  return _remove.apply( this, arguments );
+  return this.each(function() {
+    if ( !keepData ) {
+      if ( !selector || $.filter( selector, [ this ] ).length ) {
+        $( "*", this ).add( this ).each(function() {
+          $( this ).triggerHandler( "remove" );
+        });
+      }
+    }
+    return _remove.call( $(this), selector, keepData );
+  });
 };
 
 $.widget = function( name, base, prototype ) {

0 notes on commit `f775b00` Show line notes below

Please log in to comment.

...	...	@@ -12,12 +12,16 @@
12	12	var _remove = $.fn.remove;
13	13
14	14	$.fn.remove = function( selector, keepData ) {
15		- if ( !keepData ) {
16		- $( "*", this ).add( this ).each(function() {
17		- $( this ).triggerHandler( "remove" );
18		- });
19		- }
20		- return _remove.apply( this, arguments );
	15	+ return this.each(function() {
	16	+ if ( !keepData ) {
	17	+ if ( !selector \|\| $.filter( selector, [ this ] ).length ) {
	18	+ $( "*", this ).add( this ).each(function() {
	19	+ $( this ).triggerHandler( "remove" );
	20	+ });
	21	+ }
	22	+ }
	23	+ return _remove.call( $(this), selector, keepData );
	24	+ });
21	25	};
22	26
23	27	$.widget = function( name, base, prototype ) {

jquery / jquery-ui

0 notes on commit f775b00 Show line notes below

0 notes on commit `f775b00` Show line notes below