Use pushStack in widget method. Fixes #5732 - make the widget method …

…maintain the stack
jquery · Jul 30, 2010 · ea58cd5ac0d852a9c7d7ceadbcbb74006cf9052d · ea58cd5 · scottgonzalez · Jul 30, 2010
1 parent b3940d2
commit ea58cd5ac0d852a9c7d7ceadbcbb74006cf9052d
diff --git a/tests/unit/autocomplete/autocomplete_methods.js b/tests/unit/autocomplete/autocomplete_methods.js
@@ -38,6 +38,14 @@ test("search", function() {
 	same( $(".ui-menu .ui-menu-item").length, 2, "only java and javascript for 'ja'" );
 
 	$("#autocomplete").autocomplete("destroy");
-})
+});
+
+test("widget", function() {
+	var ac = $("#autocomplete").autocomplete({
+		source: data
+	});
+	same(ac.autocomplete("widget")[0], $(":ui-menu")[0]);
+	same(ac.autocomplete("widget").end()[0], ac[0]);
+});
 
 })(jQuery);
diff --git a/tests/unit/button/button_methods.js b/tests/unit/button/button_methods.js
@@ -16,4 +16,18 @@ test("destroy", function() {
 	equal( afterHtml, beforeHtml );
 });
 
+test("widget", function() {
+	var submit = $("#submit").button();
+	same(submit.button("widget")[0], submit[0]);
+	same(submit.button("widget").end()[0], submit[0]);
+
+	var check = $("#check").button();
+	same(check.button("widget")[0], check.next("label")[0]);
+	same(check.button("widget").end()[0], check[0]);
+
+	var radio = $("#radio01").button();
+	same(radio.button("widget")[0], radio.next("label")[0]);
+	same(radio.button("widget").end()[0], radio[0]);
+});
+
 })(jQuery);
diff --git a/tests/unit/dialog/dialog_methods.js b/tests/unit/dialog/dialog_methods.js
@@ -130,4 +130,10 @@ test("open", function() {
 	ok(dlg().is(':visible') && !dlg().is(':hidden'), 'dialog visible after open method called');
 });
 
+test("widget", function() {
+	var dialog = $('<div></div>').dialog();
+	same(dialog.dialog("widget")[0], dialog.parent()[0]);
+	same(dialog.dialog("widget").end()[0], dialog[0]);
+});
+
 })(jQuery);
diff --git a/tests/unit/widget/widget_core.js b/tests/unit/widget/widget_core.js
@@ -151,18 +151,21 @@ test(".widget() - base", function() {
 		_create: function() {}
 	});
 	var div = $("<div></div>").testWidget()
-	same(div[0], div.testWidget("widget")[0]);
+	same(div.testWidget("widget")[0], div[0]);
+	same(div.testWidget("widget").end()[0], div[0]);
 });
 
 test(".widget() - overriden", function() {
 	var wrapper = $("<div></div>");
 	$.widget("ui.testWidget", {
 		_create: function() {},
 		widget: function() {
-			return wrapper;
+			return this.element.pushStack(wrapper.get());
 		}
 	});
-	same(wrapper[0], $("<div></div>").testWidget().testWidget("widget")[0]);
+	var div = $("<div></div>").testWidget();
+	same(div.testWidget("widget")[0], wrapper[0]);
+	same(div.testWidget("widget").end()[0], div[0]);
 });
 
 })(jQuery);
diff --git a/ui/jquery.ui.autocomplete.js b/ui/jquery.ui.autocomplete.js
@@ -311,7 +311,7 @@ $.widget( "ui.autocomplete", {
 	},
 
 	widget: function() {
-		return this.menu.element;
+		return this.element.pushStack(this.menu.element.get());
 	}
 });
 

diff --git a/ui/jquery.ui.button.js b/ui/jquery.ui.button.js
@@ -210,7 +210,7 @@ $.widget( "ui.button", {
 	},
 
 	widget: function() {
-		return this.buttonElement;
+		return this.element.pushStack(this.buttonElement.get());
 	},
 
 	destroy: function() {

diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
@@ -207,7 +207,7 @@ $.widget("ui.dialog", {
 	},
 
 	widget: function() {
-		return this.uiDialog;
+		return this.element.pushStack(this.uiDialog.get());
 	},
 
 	close: function(event) {

diff --git a/ui/jquery.ui.widget.js b/ui/jquery.ui.widget.js
@@ -160,7 +160,7 @@ $.Widget.prototype = {
 	},
 
 	widget: function() {
-		return this.element;
+		return this.element.pushStack(this.element.get());
 	},
 
 	option: function( key, value ) {